D25055: [containments/desktop] Delete the "Tweaks" page and its options

This revision was automatically updated to reflect the committed changes. Closed by commit R119:69d649e5aab4: [containments/desktop] Delete the Tweaks page and its options (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. Thanks for your flexibility, @mart. :) REPOSITORY R119 Plasma Desktop BRANCH delete-tweaks-page (branched from master) REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: fabianr, broulik, plasma-devel, LeGast00n,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

fabianr added a comment. I would In D25055#557216 , @hein wrote: > If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox? > > I have to admit though

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. In D25055#557216 , @hein wrote: > I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once you've learned it's possible, is always going to be an

D25055: [containments/desktop] Delete the "Tweaks" page and its options

hein added a comment. If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox? I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. Ahh, I wasn't hovering for long enough. I see it now. After finally understanding and using this feature, I really think we should discard it. Actually explaining it in the UI in a way that would make it comprehensible would require an incredibly wordy checkbox

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. In D25055#556797 , @ngraham wrote: > In D25055#556755 , @mart wrote: > > > In D25055#556752 , @ngraham wrote: > > > > > In

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. In D25055#556755 , @mart wrote: > In D25055#556752 , @ngraham wrote: > > > In D25055#556751 , @mart wrote: > > > > > I would

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. In D25055#556756 , @GB_2 wrote: > I wonder, can that be added to mouse actions instead of a page with only one option? makes sense REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25055: [containments/desktop] Delete the "Tweaks" page and its options

GB_2 added a comment. I wonder, can that be added to mouse actions instead of a page with only one option? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. In D25055#556752 , @ngraham wrote: > In D25055#556751 , @mart wrote: > > > I would prefer keeping the press to move stuff > > > As far as I could tell, the option on this

D25055: [containments/desktop] Delete the "Tweaks" page and its options

GB_2 added a comment. In D25055#556751 , @mart wrote: > I would prefer keeping the press to move stuff Is there a reason to disable it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. I would prefer keeping the press to move stuff REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham marked an inline comment as done. ngraham added a comment. In D25055#556751 , @mart wrote: > I would prefer keeping the press to move stuff As far as I could tell, the option on this page doesn't actually change anything anymore.

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > broulik wrote in main.qml:268 > A conf update isn't needed as it's this code hiding the toolbox when > disabled, so without it it will just always show Ah of course! REPOSITORY R119 Plasma Desktop

D25055: [containments/desktop] Delete the "Tweaks" page and its options

broulik added a comment. +1 INLINE COMMENTS > main.qml:268 > -property: "visible" > -value: plasmoid.configuration.showToolbox > -} A conf update isn't needed as it's this code hiding the toolbox when disabled, so without it it will just always show REPOSITORY R119

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. It occurs to me that we'll need a kconf update script to turn the desktop toolbox back on for all the legions of people who turned off via this setting that I'm removing here, or else the new global edit mode won't work for them. REPOSITORY R119 Plasma Desktop

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham created this revision. ngraham added reviewers: mart, GB_2, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY With the new global edit mode, both of the options on the Tweaks page become