D25185: Icon: solve threading issue on when the source is http

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5cc8be3cd1fd: Icon: solve threading issue on when the source is http (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69422=69957

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69422. apol edited the summary of this revision. apol added a comment. simplify connect REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69421=69422 BRANCH apol/iconthreading REVISION DETAIL

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69421. apol added a comment. Update commit text REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69420=69421 BRANCH apol/iconthreading REVISION DETAIL https://phabricator.kde.org/D25185 AFFECTED FILES

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69420. apol added a comment. Simplify the multithread situation with updatePolish REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69372=69420 BRANCH apol/iconthreading REVISION DETAIL

D25185: Icon: solve threading issue on when the source is http

davidedmundson added a comment. Certainly doing all this inside updatePaintNode was wrong. So, concept wise ++ I don't understand the mutex, the main point of the patch is so that we only do network stuff on the main thread. During updatePaintNode the GUI thread is explicitly locked.

D25185: Icon: solve threading issue on when the source is http

apol added a comment. In D25185#559486 , @anthonyfieroni wrote: > Can we just use queued connection, it'll avoid mutex weirdness. Well, no. In fact, m_source is being accessed too unguarded from the different threads. REPOSITORY R169

D25185: Icon: solve threading issue on when the source is http

anthonyfieroni added a comment. Can we just use queued connection, it'll avoid mutex weirdness. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25185 To: apol, #kirigami, mart Cc: anthonyfieroni, bcooksley, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D25185: Icon: solve threading issue on when the source is http

bcooksley added a comment. As a reminder, please ensure that all QNetworkAccessManager code is built to force handling of redirects on - code that interacts with KDE.org and does not explicitly handle redirects is not supported by Sysadmin. REPOSITORY R169 Kirigami REVISION DETAIL

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69372. apol added a comment. deadlock REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69371=69372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25185 AFFECTED FILES src/icon.cpp src/icon.h

D25185: Icon: solve threading issue on when the source is http

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY For starters, QQmlEngine::networkAccessManager is not reentrant and would give us a warning