This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ff86f0abb454: KCM launchfeedback : port to KConfig XT
(authored by crossi).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25290?vs=69794&id=70281
REVISION
crossi added inline comments.
INLINE COMMENTS
> ervin wrote in main.qml:33
> Or... but that's more work and I'd say it should come in another patch on top
> of that one. We migrate the config file to use an enum all the way. This
> boolean trap exists in the config after all.
Added enum to rem
crossi updated this revision to Diff 69794.
crossi added a comment.
Add enum declaration to make boolean settings in qml a bit more readable.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25290?vs=69745&id=69794
REVISION DETAIL
https://phabricato
ervin added inline comments.
INLINE COMMENTS
> crossi wrote in main.qml:33
> I agree it's a bit tricky, we have a kind of enum choice written as a binary
> representation in the config file.
>
> Will try to work it with a QML enum to make it less confusing.
Or... but that's more work and I'd s
crossi updated this revision to Diff 69745.
crossi added a comment.
Use proper signal handler & Fix typo
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25290?vs=69683&id=69745
REVISION DETAIL
https://phabricator.kde.org/D25290
AFFECTED FILES
kc
crossi added inline comments.
INLINE COMMENTS
> broulik wrote in main.qml:33
> Yes, I would prefer all of this to be abstracted away from the QML, the
> `checked` bindings area also quite messy
I agree it's a bit tricky, we have a kind of enum choice written as a binary
representation in the c
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in main.qml:45
> onToggled is called both when it is checked, and presumably when it is
> unchecked (or another button is checked)
>
> I assume we want something more like:
>
> onToggled: {if (!checked) return; formLayout.s
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in main.qml:33
> This is a bit of a boolean trap.
>
> We could declare an enum in QML
> setCursorSettings(Busy | Blinking) would be a bit nicer maybe?
>
> Up to you.
Yes, I would prefer all of this to be abstracted away fro
davidedmundson added a comment.
Wow, we're almost at a stage where we don't need to load a C++ plugin at all.
INLINE COMMENTS
> main.qml:33
>
> -Connections {
> -target: kcm
> -
> -onBusyCursorCurrentIndexChanged: applyBusyCursorCurrentIndex()
> -
> -
ngraham added a comment.
So much red!
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25290
To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, alexeym
crossi created this revision.
crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.
REVISION SUMMARY
Simple KCM, all settings' states are automatically handled thanks
11 matches
Mail list logo
