D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari closed this revision. gikari added a comment. https://phabricator.kde.org/R99:b6e7c6f056740e936adc94b7a843f6448f6830ab REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari, #plasma, cblack, apol, jgrulich, ngraham Cc: cfeck,

D25324: [GTK Config] Add XSettingsd as a runtime dependency

jriddell added a comment. I don't think this is adding a new dependency just highlighting that there is one, so it's good to add to stable branches REPOSITORY R99 KDE Gtk Configuration Tool BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL

D25324: [GTK Config] Add XSettingsd as a runtime dependency

ngraham added subscribers: jriddell, cfeck. ngraham added a comment. We can't add a new required dependency since dependencies are frozen in the stable branches. Not sure what the policy is regarding adding optional ones though. @cfeck/@jriddell? REPOSITORY R99 KDE Gtk Configuration Tool

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. Ok. So, can I land it or should I wait for other reviewers? Also, should I make the dependency `REQUIRED` or leave it optional? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL

D25324: [GTK Config] Add XSettingsd as a runtime dependency

eszlari added a comment. In D25324#624299 , @gikari wrote: > In D25324#624229 , @eszlari wrote: > > > This bug is not fixed by this patch. `xsettingsd` needs to be started in

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. In D25324#624229 , @eszlari wrote: > This bug is not fixed by this patch. `xsettingsd` needs to be started in `plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future). `xsettingsd` is started by

D25324: [GTK Config] Add XSettingsd as a runtime dependency

eszlari added a comment. > BUG: 418263 This bug is not fixed by this patch. `xsettingsd` needs to be started in `plasma-workspace/startkde/startplasma.cpp` (or by systemd in the future). > FIXED-IN: 5.19 I would be nice, if this could make it to 5.18, so that `xsettingsd` would

D25324: [GTK Config] Add XSettingsd as a runtime dependency

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH xsettingsd-dependency (branched from master) REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari, #plasma,

D25324: [GTK Config] Add XSettingsd as a runtime dependency

gikari added a comment. Ping! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25324 To: gikari, #plasma, cblack, apol, jgrulich Cc: eszlari, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,