D25351: [Style KCM] Change name to KDE/Qt Application Style

ngraham added a comment. In D25351#563678 , @GB_2 wrote: > In D25351#563677 , @ngraham wrote: > > > I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the

D25351: [Style KCM] Change name to KDE/Qt Application Style

GB_2 added a comment. In D25351#563677 , @ngraham wrote: > I think the only way to satisfactorily do that is to remove the GTK KCM entirely, and then the remaining KCM can keep its current name ("Application Style"). I'm in favor of that, but

D25351: [Style KCM] Change name to KDE/Qt Application Style

ngraham added a comment. In D25351#563619 , @broulik wrote: > Do we really want the user having to be aware there's something like different toolkits? Not a fan of this change. We are already surfacing this distinction by having a KCM

D25351: [Style KCM] Change name to KDE/Qt Application Style

ndavis added a comment. In D25351#563617 , @davidre wrote: > Why KDE/Qt Application style? Every Qt Application will have that style and not only KDE Applications. I also fear that somehow this will strengthen the false idea of some users that

D25351: [Style KCM] Change name to KDE/Qt Application Style

broulik added a comment. Do we really want the user having to be aware there's something like different toolkits? Not a fan of this change. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D25351 To: ndavis, #plasma, #vdg, ngraham Cc: broulik,

D25351: [Style KCM] Change name to KDE/Qt Application Style

davidre added a comment. Why KDE/Qt Application style? Every Qt Application will have that style and not only KDE Applications. I also fear that somehow this will strengthen the false idea of some users that Applications and Plasma are intertwined. REPOSITORY R119 Plasma Desktop BRANCH

D25351: [Style KCM] Change name to KDE/Qt Application Style

ndavis added a subscriber: cblack. ndavis added a comment. In D25351#563601 , @GB_2 wrote: > I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the

D25351: [Style KCM] Change name to KDE/Qt Application Style

GB_2 added a comment. I thought we wanted to merge the GTK Application Style with this KCM, and have the GTK theme comboxes accessible with a button in the KCM (like for the toolbar style)? I wouldn't rename the KCM until we are sure that we don't want to merge the two KCMs. REPOSITORY

D25351: [Style KCM] Change name to KDE/Qt Application Style

ndavis updated this revision to Diff 69867. ndavis added a comment. - Remove translation changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25351?vs=69866=69867 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25351 AFFECTED

D25351: [Style KCM] Change name to KDE/Qt Application Style

ngraham added inline comments. INLINE COMMENTS > kcm_style.desktop:22 > Name[de]=Anwendungs-Stil > -Name[en_GB]=Application Style > +Name[en_GB]=KDE/Qt Application Style > Name[es]=Estilo de la aplicación Don't change translations (even English ones) > metadata.desktop:8 >

D25351: [Style KCM] Change name to KDE/Qt Application Style

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY To give it a more accurate name and prevent it from being confused with the Application Style