D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham added a comment. Yep, now you just need to merge `Plasma/5.17` into `master. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 for the full set of recommended instructions for landing a change on the stable branch REPOSITORY R114 Plasma

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe added a comment. In D25354#564187 , @ngraham wrote: > 5.17 branch please. Not sure if I did it correctly... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma, ngraham

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R114:e8402b9a3156: Fix POTD config ComboBox display issue in Lock Screen KCM (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.17 branch please. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel,

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe updated this revision to Diff 69929. guoyunhe added a comment. Move string changes to another patch REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25354?vs=69922=69929 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25354

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham added a comment. +1 for simplifying the strings, but keep in mind that any change that alters strings, can't be a bugfix on the stable branch and needs to be master-only. Might be better to only made the code changes on the stable branch, and do the string changes in a separate

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe updated this revision to Diff 69922. guoyunhe edited the summary of this revision. guoyunhe added a comment. Shorten POTD provider names and remove descriptions that are never used anywhere. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe added a comment. Another approach is to shorten the texts: F7769821: image.png REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25354 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n,

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

ngraham added a comment. I can confirm the bug and that this fixes it. However, you're porting to use the QQC2 Combobox even though https://bugs.kde.org/show_bug.cgi?id=403153 isn't fixed yet. As a result, the pop-up looks like this a lot of the time: F7768289:

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY BUG: 412976 TEST PLAN Open Lock Screen KCM. Change wallpaper type to Picture of The Day. Check the ComboBox of POTD.