This revision was automatically updated to reflect the committed changes.
Closed by commit R134:36bf9e7a51fe: fix layout of overlaysheet (authored by
mart).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25430?vs=70335=70336
REVISION DETAIL
mart updated this revision to Diff 70335.
mart marked 2 inline comments as done.
mart added a comment.
- adress comments
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25430?vs=70081=70335
BRANCH
phab/overlaysheet
REVISION DETAIL
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Change looks good to me. Please resolve the comments before landing.
INLINE COMMENTS
> DummyTransaction.cpp:52
> setProgress(qBound(0, progress()+(KRandom::random()%30), 100));
> -
ngraham added inline comments.
INLINE COMMENTS
> ProgressView.qml:60
> separatorVisible: false
> +//implicitWidth: 400//tasksView.width
> hoverEnabled: model.application
Needed?
REPOSITORY
R134 Discover Software Store
REVISION
mart created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
makes the overlaysheet howit's supposed to be rendered:
since it's "global" in the app, it should be parented to the
