D25580: [System Tray] Unified data model for System Tray items

kmaterka added a comment. In D25580#578732 , @trmdi wrote: > Please make sure it would not bring this bug back: https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989 I double checked that. If I understand correctly

D25580: [System Tray] Unified data model for System Tray items

trmdi added a comment. Please make sure it would not bring this bug back: https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma, broulik, ngraham, nicolasfella

D25580: [System Tray] Unified data model for System Tray items

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d2fa8e6b812: [System Tray] Unified data model for System Tray items (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25580: [System Tray] Unified data model for System Tray items

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma, broulik, ngraham, nicolasfella Cc:

D25580: [System Tray] Unified data model for System Tray items

kmaterka updated this revision to Diff 71232. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=71231=71232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25580 AFFECTED FILES

D25580: [System Tray] Unified data model for System Tray items

kmaterka updated this revision to Diff 71231. kmaterka marked 5 inline comments as done. kmaterka added a comment. Review fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25580?vs=70464=71231 BRANCH master REVISION DETAIL

D25580: [System Tray] Unified data model for System Tray items

kmaterka marked 5 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > nicolasfella wrote in ConfigEntries.qml:68 > You can try doing > > for (item of systemTrayModel) { > ] > > But I don't know if that will work Unfortunately model is not iterable. This code will be

D25580: [System Tray] Unified data model for System Tray items

nicolasfella added a comment. Looks very good in general. A few style nitpicks INLINE COMMENTS > ConfigEntries.qml:68 > var list = []; > -for (var i = 0; i < statusNotifierModel.count; ++i) { > -var item = statusNotifierModel.get(i); > -list.push({ >

D25580: [System Tray] Unified data model for System Tray items

kmaterka added a comment. This is a simplified version of D23413 needed for the D22176 to move forward. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma,

D25580: [System Tray] Unified data model for System Tray items

kmaterka created this revision. kmaterka added reviewers: Plasma, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Currently there are two different sources of SystemTray items: - Plasmoids - Status Notifier Thi change adds new