D25670: Synchronize decorations buttons order in GTK headerbars

trmdi added a comment. Excuse me, could you have a look to see if this bug relates to this patch or not? https://www.reddit.com/r/kde/comments/imnpny/firefox_global_menu_patch_removes_the_headerbar/ REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D25670: Synchronize decorations buttons order in GTK headerbars

This revision was automatically updated to reflect the committed changes. Closed by commit R99:2b12ceb1b891: Synchronize decorations buttons order in GTK headerbars (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D25670: Synchronize decorations buttons order in GTK headerbars

gikari updated this revision to Diff 71810. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25670?vs=70782=71810 BRANCH gtk-decoration-order-sync (branched from master) REVISION DETAIL

D25670: Synchronize decorations buttons order in GTK headerbars

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Never mind my last message, that's okay. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH gtk-decoration-order-sync (branched from master) REVISION DETAIL

D25670: Synchronize decorations buttons order in GTK headerbars

gikari added a comment. In D25670#579888 , @apol wrote: > This looks like it's trying to change configurations from other sources. This feels wrong. Could you elaborate on that? What do you mean exactly? What other sources? Do you mean

D25670: Synchronize decorations buttons order in GTK headerbars

apol added a comment. This looks like it's trying to change configurations from other sources. This feels wrong. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To: gikari, #vdg, cblack, #plasma Cc: apol, GB_2, broulik, plasma-devel,

D25670: Synchronize decorations buttons order in GTK headerbars

GB_2 added a comment. Works great! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To: gikari, #vdg, cblack, #plasma Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D25670: Synchronize decorations buttons order in GTK headerbars

gikari updated this revision to Diff 70782. gikari added a comment. - Change appmenu to icon REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25670?vs=70778=70782 BRANCH gtk-decoration-order-sync (branched from master) REVISION DETAIL

D25670: Synchronize decorations buttons order in GTK headerbars

gikari updated this revision to Diff 70778. gikari edited the test plan for this revision. gikari added a comment. - Use KConfigWatcher instead of KWin dbus signal REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25670?vs=70705=70778

D25670: Synchronize decorations buttons order in GTK headerbars

broulik added a comment. > It would be sensible to use an individual signal. I would like to hear an advice about its naming. Alternatively you could have the KWin decoration KCM use `writeEntry` with `Notify` flag and then use a `KConfigWatcher` here instead of connecting to KWin's

D25670: Synchronize decorations buttons order in GTK headerbars

gikari added a comment. In D25670#570517 , @cblack wrote: > You would probably want to use `icon` instead of `menu`, as `menu` is only rendered as a fallback for a pattern that most GNOME applications don't use nowadays. > > Edit:

D25670: Synchronize decorations buttons order in GTK headerbars

cblack added a comment. You would probably want to use `icon` instead of `menu`, as `menu` is only rendered as a fallback for a pattern that most GNOME applications don't use nowadays. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To:

D25670: Synchronize decorations buttons order in GTK headerbars

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Window decorations button order was applied only for window headers that was controlled by KWin, but not for GTK applications with