D25744: support userBackgroundhints in the scripting ui

2019-12-05 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:786951fec803: support userBackgroundhints in the scripting ui (authored by mart). REPOSITORY R120 Plasma Workspace

D25744: support userBackgroundhints in the scripting ui

2019-12-04 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > apol wrote in widget.h:71 > const& > > or should it be Plasma::Types::BackgroundHints? everthing else presents strings to the engine. i don't know if it's possible making enums work correctly with qjsengine (that is without qml) REPOSITORY

D25744: support userBackgroundhints in the scripting ui

2019-12-04 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > widget.h:71 > +QString userBackgroundHints() const; > +void setUserBackgroundHints(QString hint); > + const& or should it be Plasma::Types::BackgroundHints? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25744: support userBackgroundhints in the scripting ui

2019-12-04 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY bind userBackgroundHints to the desktopscript interface TEST PLAN from the scripting console is