davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> 60: StylePrivate.PropertyWriter is not a type
Sounds like you just had your QQC2 style broken.
In any case, this code all looks fine.
Better to have to port one
ognarb updated this revision to Diff 71733.
ognarb marked 2 inline comments as done.
ognarb added a comment.
- fix naming
REPOSITORY
R118 Plasma SDK
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25778?vs=71732=71733
BRANCH
arcpatch-D25778
REVISION DETAIL
ognarb added inline comments.
INLINE COMMENTS
> guoyunhe wrote in MetadataEditor.qml:108
> This need to be changed to `QQC2.ComboBox`
I tried but I get
Type QQC2.ComboBox unavailable
60: StylePrivate.PropertyWriter is not a type
REPOSITORY
R118 Plasma SDK
REVISION DETAIL
ognarb updated this revision to Diff 71732.
ognarb marked 2 inline comments as done.
ognarb added a comment.
- Use same button width as for the text field
- Fix dialog not closing
- Improve margin
REPOSITORY
R118 Plasma SDK
CHANGES SINCE LAST UPDATE
GB_2 added a comment.
Ping.
REPOSITORY
R118 Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D25778
To: ognarb, #vdg, #plasma
Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
filipf added inline comments.
INLINE COMMENTS
> main.qml:97
> fill: parent
> margins: 10
> }
I would do something standardized like largeSpacing.
> main.qml:100
> +Layout.alignment: Qt.AlignHCenter
> +ColumnLayout {
> +
guoyunhe added a comment.
If your use `as QQC2` in your imports, `ComboBox` need to be changed to
`QQC2.ComboBox`.
INLINE COMMENTS
> MetadataEditor.qml:108
> }
> ComboBox {
> id: licenseField
This need to be changed to `QQC2.ComboBox`
ognarb added inline comments.
INLINE COMMENTS
> main.qml:46
> titleIcon: "preferences-desktop-theme"
> +modal: true;
> +collapsible: false;
This sadly didn't work :(
REPOSITORY
R118 Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D25778
To: ognarb, #vdg,
ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.
REVISION SUMMARY
I wasn't able to convert the conbox box :(
I'm getting a strange error
TEST PLAN
Screenshot comming
REPOSITORY
R118 Plasma
