D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. ahiemstra marked an inline comment as done. Closed by commit R1014:693c491bc577: Add an option to enable QML profiling (authored by ahiemstra). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabri

D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra
ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > bshah wrote in CMakeLists.txt:33 > Commit description and code doesn't match :) D'oh. REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D25879 To: ahiemstra, #kirigam

D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 71264. ahiemstra added a comment. - Actually set qml profiling to ON by default REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25879?vs=71263&id=71264 BRANCH qmlprofiling REVISION DETAIL https://phabri

D25879: Add an option to enable QML profiling

2019-12-11 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a CMake option to enable QML profiler and debugger integration. This

D25879: Add an option to enable QML profiling

2019-12-11 Thread Bhushan Shah
bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:33 > > +option(ENABLE_QML_PROFILING "Enable QML profiler support" OFF) > + Commit description and code doesn't match :) REPOSITORY R1014 Kir