D25920: [KCMs/Night Color] Make activation criteria and times more obvious

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2a42a15cdf68: [KCMs/Night Color] Make activation criteria and times more obvious (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

filipf accepted this revision. filipf added a comment. Looks good. I just realized that maybe the message at the top could be an info inline message, but I see how that could be too much. REPOSITORY R119 Plasma Desktop BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71461. ngraham added a comment. Address other VDG comments from chatroom (add time labels to main formlayout and align) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71460=71461 BRANCH

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71460. ngraham added a comment. Address VDG review comments from here REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71430=71460 BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham added a comment. In D25920#576966 , @abetts wrote: > Suggestions: > > "To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing" > > Change to: > > "Night Color makes the screen

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

abetts added a comment. Suggestions: "To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing" Change to: "Night Color makes the screen colors warmer to reduce eye strain" "Night color temperature" Change to:

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71430. ngraham added a comment. Put the separator in the formlayout for more simplicity REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71429=71430 BRANCH polish-nightcolor-ui (branched from master)

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71429. ngraham added a comment. Restore original import order for timings view now that we don't need layouts anymore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71428=71429 BRANCH

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71428. ngraham added a comment. Put the labels back in a FormLayout to align the times, but don't align the formlayout itself with the top one or else the whole thing is too far over to the left REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham added a comment. This idea was to have a top-to-bottom flow. First you turn it on, then you select the activation mode, then you manipulate the controls specific to that mode (if applicable), then you see the times that result from those settings. I think it makes logical sense. If

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

romangg added a comment. Sorry, but I don't like how the text is "hanging in the air" and how it is jumping around when changing the setting. REPOSITORY R119 Plasma Desktop BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D25920 To:

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71419. ngraham added a comment. Polish everything even more to ensure a consistent top-to-bottom workflow. To do this I had to do a lot of refactoring that also has the side effect of making the UI a lot more declarative. REPOSITORY R119 Plasma

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71399. ngraham added a comment. Improve begin/end strings again REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71387=71399 BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

romangg added a comment. One more thing I forgot: strings "Turn on at" and "Fully on at" and so on are too unclear for me and also sound a bit dumb. ;) Proposal: "Begin shift at" and "Fully engaged at". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25920

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71387. ngraham added a comment. Tweak location-related mode strings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71381=71387 BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham added a comment. In D25920#576403 , @romangg wrote: > Yea, new strings are better. I like the overall look of the KCM in this redesign. Thanks! > Maybe the description at the top could be in some kind of "info" box or in

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

romangg added a comment. Yea, new strings are better. I like the overall look of the KCM in this redesign. Maybe the description at the top could be in some kind of "info" box or in another way better styled? For the strings: `Sunset/rise at current location`? REPOSITORY R119 Plasma

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71381. ngraham added a comment. - Disclose location usage - Use better string for manual location mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71359=71381 BRANCH polish-nightcolor-ui

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham created this revision. ngraham added reviewers: VDG, Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch polishes the Night Color UI to make it more obvious what the