D25978: Don't hardcode the margin of the CardsListView

2019-12-14 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:2757a17bb089: Dont hardcode the margin of the CardsListView (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25978?vs=71491=71504 REVISION

D25978: Don't hardcode the margin of the CardsListView

2019-12-14 Thread Aleix Pol Gonzalez
apol added a comment. The path is private but the class is directly inherited. 路 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25978 To: apol, #kirigami Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart,

D25978: Don't hardcode the margin of the CardsListView

2019-12-14 Thread David Edmundson
davidedmundson added a comment. Makes sense, but I don't understand how this helps, given the path is "private/" ? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25978 To: apol, #kirigami Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D25978: Don't hardcode the margin of the CardsListView

2019-12-14 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use the left/rightMargin properties with a default value, in case it makes sense to override it.