This revision was automatically updated to reflect the committed changes.
Closed by commit R134:34d68d4ec5a5: Fix usage of deprecated QSet/QList methods
(authored by alexeymin).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
alexeymin added a comment.
Should be fine now?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D26069
To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,
alexeymin updated this revision to Diff 71749.
alexeymin added a comment.
I feel sad doing such things
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26069?vs=71748=71749
BRANCH
arcpatch-D26069
REVISION DETAIL
alexeymin updated this revision to Diff 71748.
alexeymin added a comment.
Add QT_VERSION_CHECK checks
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26069?vs=71731=71748
BRANCH
arcpatch-D26069
REVISION DETAIL
alexeymin added a comment.
No :( just checked, Qt 5.12's
https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qset.h?h=v5.12.0
is missing `inline QSet(InputIterator first, InputIterator last)`, which
appeared only in 5.14.
I guess I need an `#ifdef` for QSet construction then.
apol added a comment.
Will all of this build on Qt 5.12?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D26069
To: alexeymin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,
alexeymin created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alexeymin requested review of this revision.
REVISION SUMMARY
COmpiiling with Qt 5.14 produces the following warnings:
.../libdiscover/resources/StandardBackendUpdater.cpp:70:43:
