D26398: [KCM/Activities] Use KConfigXT in ui

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec73805eb2bf: [KCM/Activities] Use KConfigXT in ui (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73063=73977 REVISION DETAIL

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73063. meven added a comment. Only once commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73062=73063 BRANCH arcpatch-D26398 REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED FILES

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73062. meven marked an inline comment as done. meven added a comment. Add Q_ASSERTs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73056=73062 BRANCH arcpatch-D26398 REVISION DETAIL

D26398: [KCM/Activities] Use KConfigXT in ui

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > BlacklistedApplicationsModel.cpp:191 > +emit > changed(d->pluginConfig->findItem("blockedApplications")->isSaveNeeded() && >

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73056. meven marked 2 inline comments as done. meven added a comment. Improve signals naming, and remove redundant ones REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73055=73056 BRANCH arcpatch-D26398

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73055. meven marked 2 inline comments as done. meven added a comment. In BlackListModel only acces concerned items isSaveNeeded and isDefault REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=73054=73055

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 73054. meven marked 2 inline comments as done. meven added a comment. Review, code style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72964=73054 BRANCH arcpatch-D26398 REVISION DETAIL

D26398: [KCM/Activities] Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > ervin wrote in BlacklistedApplicationsModel.cpp:179 > I personally like that construct, but AFAIK it's rather unusual in KDE code, > so maybe for the sake of the future developer use something more "classic". > Either: > > const auto name =

D26398: [KCM/Activities] Use KConfigXT in ui

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. A few changes needed to make the code easier to understand in a few months time. Also there's a larger concern of a piece of code being prone to later bugs (although I'd expect it

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72964. meven added a comment. Handle BlacklistedApplicationsModel properly, prevent a warning 'duplicate connection name' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72850=72964 BRANCH

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72850. meven added a comment. Remove unwanted change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72849=72850 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED FILES

D26398: [KCM/Activities] Use KConfigXT in ui

meven updated this revision to Diff 72849. meven added a comment. KCM/Component clean unused file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26398?vs=72695=72849 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26398 AFFECTED

D26398: [KCM/Activities] Use KConfigXT in ui

meven created this revision. meven added reviewers: Plasma, ervin, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Port the ui components to use KConfig XT features to reduce amount of boilerplate code.