This revision was automatically updated to reflect the committed changes.
Closed by commit R134:ec5464e70642: Only show full name in review dialog
(authored by ngraham).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26421?vs=72767=73582
ngraham added a comment.
Thanks!
REPOSITORY
R134 Discover Software Store
BRANCH
full-name-only (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26421
To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
ngraham added a comment.
@apol ping.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D26421
To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot,
jgrulich added a comment.
I don't really remember, but I can see in the userHash() it's not used so
this is probably safe. In the userHash() we directly use KUser().
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D26421
To: ngraham,
apol added a subscriber: jgrulich.
apol added a comment.
@jgrulich you included that, right? Do you remember why? I can see it's used
for generating the user hash.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D26421
To: ngraham,
ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The review gets submitted with your full name, but the review dialog
