D26531: [Wallpaper] Show author as subtitle in configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3729873fdd1d: [Wallpaper] Show author as subtitle in configuration (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. Submitted a patch to fix it: D26634 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. I'll look into it, yeah. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26531: [Wallpaper] Show author as subtitle in configuration

mart added a comment. In D26531#592814 , @broulik wrote: > > can you look into that? > > Perhaps @ngraham can. In any case, if this were fixed, it would not make it for 5.18. no biggie. let's put it in as soon as the new cycle starts

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > can you look into that? Perhaps @ngraham can. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26531: [Wallpaper] Show author as subtitle in configuration

mart added a comment. In D26531#590729 , @broulik wrote: > > However I see a problem with the delegate cell size: > > That's unrelated and something I would have expected was tested when this feature was added. can you look into

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > "By" can also be tricky to translate into other languages That's why we have context. Currently it also has " by " explanation. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: filipf,

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > However I see a problem with the delegate cell size: That's unrelated and something I would have expected was tested when this feature was added. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma,

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. All right, let's do this way then. However I see a problem with the delegate cell size: F7871404: Screenshot_20200108_154900.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To:

D26531: [Wallpaper] Show author as subtitle in configuration

filipf added a comment. Good idea +1. I think an author's name is enough here since information is displayed in a similar way that songs info is ie. it should be obvious to everyone the second line lists the author. "By" can also be tricky to translate into other languages. In my

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. Might make sense to keep the "By" prefix, yeah. +1! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26531: [Wallpaper] Show author as subtitle in configuration

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY If we have this feature now, let's use it and give the wallpaper authors the credit they