D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. In D26572#593496 , @ndavis wrote: > What I meant is that I did not change the color of the checkbox background in this patch. I only made it so that the background would always be rendered. Clear enough.

D26572: Always render checkbox/radiobutton background

ndavis added a comment. What I meant is that I did not change the color of the checkbox background in this patch. I only made it so that the background would always be rendered. It seems like it might be a good idea to detect whether or not the button is being rendered in a view area

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. In D26572#593442 , @ndavis wrote: > In D26572#593379 , @hpereiradacosta wrote: > > > in more detail: imagine a color scheme where window background is black, window

D26572: Always render checkbox/radiobutton background

ndavis added a comment. In D26572#593379 , @hpereiradacosta wrote: > in more detail: imagine a color scheme where window background is black, window text is white, view background is white view text is black. > you will get a white square

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. in more detail: imagine a color scheme where window background is black, window text is white, view background is white view text is black. you will get a white square on a white background for unchecked checkbox ... REPOSITORY R31 Breeze REVISION

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. I would strongly object to that: first that is a visual change unrelated to the issue this patch adress second this is semantically wrong, and this will break on some color theme. Things should be kept consistent. If you change the background role, you

D26572: Always render checkbox/radiobutton background

ndavis added a comment. Oh, I should have brought this up before landing, but any opinions about always using `QPalette::Base` (View Background) for the background color? I asked on the VDG channel and people seemed to be unanimously in favor of using View Background as the background

D26572: Always render checkbox/radiobutton background

This revision was automatically updated to reflect the committed changes. Closed by commit R31:98781f18df86: Always render checkbox/radiobutton background (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26572?vs=73234=73417 REVISION DETAIL

D26572: Always render checkbox/radiobutton background

hpereiradacosta accepted this revision. hpereiradacosta added a comment. ship it. No strong feeling. REPOSITORY R31 Breeze BRANCH checkbox-radiobutton-background (branched from master) REVISION DETAIL https://phabricator.kde.org/D26572 To: ndavis, #vdg, #breeze, #plasma,

D26572: Always render checkbox/radiobutton background

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. Purely in terms of visuals, I think so. It clearly fixes a bug. REPOSITORY R31 Breeze BRANCH checkbox-radiobutton-background (branched from master) REVISION DETAIL

D26572: Always render checkbox/radiobutton background

ndavis added a comment. Since this improves checkbox visibility when rendered over images, should we or should we not do this? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26572 To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham Cc: plasma-devel,

D26572: Always render checkbox/radiobutton background

ngraham added a comment. Hugely improved visibility with this patch: F7878198: Screenshot_20200111_160828.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26572 To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham Cc:

D26572: Always render checkbox/radiobutton background

ngraham added a comment. In D26572#592280 , @hpereiradacosta wrote: > I would prefer not systematically render the background, because it might break existing applications, like rendering a widget on top of a painted image. In fact that

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. I would prefer not systematically render the background, because it might break existing applications, like rendering a widget on top of a painted image. Also this goes against Qt's rendering model which does not require rendering widget background, relying

D26572: Always render checkbox/radiobutton background

ndavis updated this revision to Diff 73234. ndavis added a comment. remove .clangd/ REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26572?vs=73231=73234 BRANCH checkbox-radiobutton-background (branched from master) REVISION DETAIL

D26572: Always render checkbox/radiobutton background

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY QQC2/Kirigami checkboxes and radio buttons can turn invisible when rendered over a selected