D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9ae855e0dcbc: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26582?vs=73

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. Let's be safe and targe 5.19 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachu

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. 5.18 or not ? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouka

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, O

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. In D26582#600469 , @hein wrote: > So does this fall through to the dialog when the type hasn't been determined Any file has always one mime type : "application/octet-stream", but KRun generally resolves mimetype thr

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

hein added a comment. So does this fall through to the dialog when the type hasn't been determined? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, j

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. ping :) @hein REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

aleksejshilin added a comment. In D26582#592469 , @meven wrote: > We may want to change KRun::runUrl when a native binary is to be run but with runExecutable is false, around line 400: > > } else if (isNativeBinary) { > // Show warn

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. In D26582#592266 , @aleksejshilin wrote: > In D26582#591959 , @meven wrote: > > > Well there was already KRun::setRunExecutables :) > > > I've already talked about it in

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

aleksejshilin added a comment. In D26582#591959 , @meven wrote: > Well there was already KRun::setRunExecutables :) I've already talked about it in my previous message: In D26582#591952 , @al

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven updated this revision to Diff 73275. meven added a comment. Use KRun::setRunExecutables REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26582?vs=73269&id=73275 BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 AF

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. Well there was already KRun::setRunExecutables :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ra

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven planned changes to this revision. meven added a comment. In D26582#591952 , @aleksejshilin wrote: > I thought about using KRun::setShowScriptExecutionPrompt() for D10835 , but "Recent Documents" include

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

aleksejshilin added a comment. I thought about using KRun::setShowScriptExecutionPrompt() for D10835 , but "Recent Documents" include only those files which were opened, and doesn't include ones which were executed, so an execution prompt there would be to

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven created this revision. meven added reviewers: Plasma, broulik, aleksejshilin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Since D10835 opening urls that needed mimet