This revision was automatically updated to reflect the committed changes.
Closed by commit R114:8861250b2e47: [applets/weather] Port weather station
picker to QQC2+ListView (authored by ngraham).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26640?vs=74
ngraham added a comment.
Ping.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D26640
To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, hi
ngraham updated this revision to Diff 74184.
ngraham marked 5 inline comments as done.
ngraham added a comment.
More review comments
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26640?vs=73780&id=74184
BRANCH
port-to-listview-in-scrollview (branc
broulik added a comment.
Using `Kirigami.SearchField` would be nice, so Ctrl+F acts as a shortcut for
getting back to the search field when focus jumped to the list.
(And can we later improve that weird workflow where no providers are selected
and the Search field is disabled for no imme
ngraham updated this revision to Diff 73780.
ngraham marked 3 inline comments as done.
ngraham added a comment.
Address review comments
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26640?vs=73464&id=73780
BRANCH
port-to-listview-in-scrollview (br
ngraham added inline comments.
INLINE COMMENTS
> broulik wrote in WeatherStationPicker.qml:144
> This is unlike any other list we have in settings?
I copied it from the notifications KCM :)
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D26640
To: ngraham, #vdg,
broulik added inline comments.
INLINE COMMENTS
> WeatherStationPicker.qml:44
> if (!success) {
> noSearchResultReport.text = i18nc("@info", "No weather stations
> found for '%1'", searchString);
> noSearchResultReport.visible = true;
Given the item is hidden a
ngraham added a comment.
Ping
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D26640
To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
ngraham updated this revision to Diff 73464.
ngraham added a comment.
Re-add busy indicator
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26640?vs=73459&id=73464
BRANCH
port-to-listview-in-scrollview (branched from master)
REVISION DETAIL
https
ngraham added a comment.
For me it was instant after this patch. But I'll re-add it.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D26640
To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas,
fvogt added a comment.
When I tested this, there was a very noticable delay (~10s) between starting
the search and items appearing, so the busy indicator is IMO necessary.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D26640
To: ngraham, #vdg, #plasma, brouli
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This fixes the bug I introduced when I fixed 414442 in the wrong way, makes
the UI m
12 matches
Mail list logo
