This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:4b4f6a3f9639: refactor about-distro to more generically
support textual dumps (authored by sitter).
CHANGED PRIOR TO
sitter added a comment.
Last chance to object.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D26667
To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
sitter updated this revision to Diff 73708.
sitter added a comment.
remove extra file
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26667?vs=73707=73708
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26667
AFFECTED FILES
sitter updated this revision to Diff 73707.
sitter added a comment.
split into one class per file
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26667?vs=73602=73707
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26667
AFFECTED FILES
sitter updated this revision to Diff 73602.
sitter added a comment.
forgot to actually write cleanup after having wanted to twice :'D
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26667?vs=73541=73602
BRANCH
master
REVISION DETAIL
sitter added a comment.
not sure if it's worth splitting into multiple files. personally I prefer
many tiny files over one long one though *shrug*.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D26667
To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
this previously relied on manually replicating strings and whatnot, it was
very awkward to read and the load functions were also
