This revision was automatically updated to reflect the committed changes.
Closed by commit R114:59cd237a7146: [TabBox] Add Thumbnail Grid window switcher
(authored by Zren).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26681?vs=73648&id=73675
REVISION
romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> Zren wrote in main.qml:183
> Uhg, I was using `width: parent.height` and `height: parent.height` but
> changed it when cleaning it up. I must've not staged all the ch
Zren updated this revision to Diff 73648.
Zren edited the summary of this revision.
Zren added a comment.
Fix implicitWidth error by using Layout.min/maxWidth.
Scale captionRow.spacing by dpi.
Take into account the close button is 30x30.
Use a ColumnLayout for thumbnailGridItems instead o
Zren added inline comments.
INLINE COMMENTS
> davidedmundson wrote in main.qml:183
> you can use Layout.preferredWidth
>
> One shouldn't specifiy a width/height from an item inside a layout
Uhg, I was using `width: parent.height` and `height: parent.height` but changed
it when cleaning it up.
zzag added inline comments.
INLINE COMMENTS
> main.qml:1
> +/
> + KWin - the KDE window manager
Bad file permissions. Needs to be 644.
> main.qml:74-76
> +var c = Math.min(thumbnailGridView.count,
> maxGridColu
davidedmundson added inline comments.
INLINE COMMENTS
> main.qml:231
> +
> +// This doesn't work, nor does keyboard input work on any other
> tabbox skin (KDE 5.7.4)
> +// It does work in the preview however.
GridView has it's own input handling you shouldn't
davidedmundson added inline comments.
INLINE COMMENTS
> romangg wrote in main.qml:183
> This must be `width: parent.height`. implicitWidth is a read-only property.
> WIthout this change the qml file won't load.
you can use Layout.preferredWidth
One shouldn't specifiy a width/height from an ite
romangg requested changes to this revision.
romangg added a reviewer: Plasma.
romangg added a comment.
This revision now requires changes to proceed.
Nice. Let's fix these few issues and get it merged before tomorrow. Other
small issues can be fixed in beta phase.
INLINE COMMENTS
> main.qml:
Zren created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.
REVISION SUMMARY
Cleaned up my code from https://github.com/Zren/kwin-tabbox-thumbnail_grid
The column is calculated recursively, but survived a stres
