D26783: Center only during drawing, not the hit rects

2020-01-21 Thread Nathaniel Graham
ngraham added a comment. There's some weirdness in System Settings too. However all of this just exposes when we have a scrollable view that should be reformatted to show everything without needing to be scrollable (e.g. Okular's settings window; see https://bugs.kde.org/show_bug.cgi?id=3976

D26783: Center only during drawing, not the hit rects

2020-01-21 Thread Noah Davis
ndavis added a comment. In D26783#598083 , @hpereiradacosta wrote: > Thanks for the fix. > On a different topics, I have found a couple more places where the separators look weird. See: > F7895454: Screenshot_20200121_102848.png

D26783: Center only during drawing, not the hit rects

2020-01-21 Thread Hugo Pereira Da Costa
hpereiradacosta added a comment. Thanks for the fix. On a different topics, I have found a couple more places where the separators look weird. See: F7895454: Screenshot_20200121_102848.png or F7895458: Screenshot_20200121_102934.png

D26783: Center only during drawing, not the hit rects

2020-01-21 Thread Marco Martin
mart added a comment. In master and 5.18 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26783 To: mart, #vdg, hpereiradacosta, ndavis Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, him

D26783: Center only during drawing, not the hit rects

2020-01-21 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R31:5a447b59fc96: Center only during drawing, not the hit rects (authored by mart). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26783?vs=73923&id=73997 REVISION DETAIL

D26783: Center only during drawing, not the hit rects

2020-01-20 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R31 Breeze BRANCH phab/centering REVISION DETAIL https://phabricator.kde.org/D26783 To: mart, #vdg, hpereiradacosta, ndavis Cc: ngraham, plasma-devel, Orage, LeGast0

D26783: Center only during drawing, not the hit rects

2020-01-20 Thread Nathaniel Graham
ngraham added a comment. Works for me. Probably 5.18 material. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26783 To: mart, #vdg, hpereiradacosta, ndavis Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, Z