D26797: KCM/Component Refactor UI to a single list of combobox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f55252fbf5d6: KCM/Component Refactor UI to a single list of combobox (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74541&id=74

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. > I may want to reconsider and simply add whatever service is in Default Application and display it, ignoring entries in "Added Associations", as I do elsewhere. I am thinking about doing this, as it makes the code more similar with other cfgplugin, and the curren

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74541. meven marked 7 inline comments as done. meven added a comment. Code formatting, add qAsConst, only search for one directory kcm_componentchooser to find its components REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

D26797: KCM/Component Refactor UI to a single list of combobox

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooser.cpp:62 > +// fill the form layout > +const auto name = cg.readEntry("Name",i18n("Unknown")); > +CfgPlugin *loadedConfigW

D26797: KCM/Component Refactor UI to a single list of combobox

meven added inline comments. INLINE COMMENTS > broulik wrote in componentchooseremail.cpp:149 > So here you do show an `entryPath` but not in the other components? For email I have a slightly more advanced logic to read and display the "Added Associations" section of mimeapps.list and add it to

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74304. meven marked 11 inline comments as done. meven added a comment. - Make CfgPlugin a QComboBox with default and currently saved index handling - General code improvements : in loops, naming... - set the minimal width of combobox 18 making them most o

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. In D26797#599747 , @filipf wrote: > A lot cleaner and straightforward now, good job. I was wondering though what it would look like if we made all the comoboboxes have equal width (if possible). I can make that hap

D26797: KCM/Component Refactor UI to a single list of combobox

filipf added a comment. A lot cleaner and straightforward now, good job. I was wondering though what it would look like if we made all the comoboboxes have equal width (if possible). REPOSITORY R119 Plasma Desktop BRANCH new-component-chooser REVISION DETAIL https://phabricator.kde.o

D26797: KCM/Component Refactor UI to a single list of combobox

broulik added inline comments. INLINE COMMENTS > componentchooser.cpp:65 > > - if (loadedConfigWidget) { > - configWidgetMap.insert(service, loadedConfigWidget); > - configContainer->addWidget(loadedConfigWidget); > - connect(loadedConfigWidget, SIGNAL(ch

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. In D26797#598189 , @ngraham wrote: > In D26797#598030 , @meven wrote: > > > @ngraham I think I should wait for some feedback/review from #VDG

D26797: KCM/Component Refactor UI to a single list of combobox

ngraham added a comment. In D26797#598030 , @meven wrote: > @ngraham I think I should wait for some feedback/review from #VDG or #Plasma to iron out issues if any.

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74012. meven added a comment. Add missing line change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74011&id=74012 BRANCH new-component-chooser REVISION DETAIL https://phabricator.kde.org/D26797 AF

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. @ngraham I think I should wait for some feedback/review from #VDG or #Plasma to iron out issues if any. REPOSITORY R119 Plasma Desktop BRANCH new-component-chooser REVISION DETAIL

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74011. meven added a comment. Add copyright mentions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74008&id=74011 BRANCH new-component-chooser REVISION DETAIL https://phabricator.kde.org/D26797 AFF

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74008. meven added a comment. change emitChanged(bool) to emitChanged() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=73993&id=74008 BRANCH new-component-chooser REVISION DETAIL https://phabricator.

D26797: KCM/Component Refactor UI to a single list of combobox

ervin added inline comments. INLINE COMMENTS > meven wrote in componentchooser.cpp:98 > I kept it as the compiler might be able to do some optimization in the loop > when val is true line 105. > It may skip the `plugin->hasChanged();` calls in that case, but I am not sure > it gcc is clever eno

D26797: KCM/Component Refactor UI to a single list of combobox

meven added inline comments. INLINE COMMENTS > ervin wrote in componentchooser.cpp:98 > I still think val is useless. I kept it as the compiler might be able to do some optimization in the loop when val is true line 105. It may skip the `plugin->hasChanged();` calls in that case, but I am not s

D26797: KCM/Component Refactor UI to a single list of combobox

ervin added inline comments. INLINE COMMENTS > componentchooser.cpp:98 > > +void ComponentChooser::emitChanged(bool val) > +{ I still think val is useless. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26797 To: meven, #plasma, #vdg, ngraham, ervin Cc: plas

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 73993. meven marked 11 inline comments as done. meven added a comment. Code formatting, only one loop in ComponentChooser::emitChanged, indentation tabs vs spaces REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D267

D26797: KCM/Component Refactor UI to a single list of combobox

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooser.cpp:80 > + > +if (cfgType==QLatin1String("internal_email")) { > +loadedConfigWidget = new CfgEmailClient(this); I know it's older c

D26797: KCM/Component Refactor UI to a single list of combobox

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wow, such a huge UI improvement. This is a pre-existing issue, but I see duplicate entries in the copy that's built from source in my pde prefix location, which looks pretty hilarious

D26797: KCM/Component Refactor UI to a single list of combobox

meven created this revision. meven added reviewers: Plasma, VDG, ngraham, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Refactor UI to a single list of Combobox: - Simplify code REPOSITORY R119 Pl