D26824: Consider empty email valid

This revision was automatically updated to reflect the committed changes. Closed by commit R128:386f6771d287: Consider empty email valid (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26824?vs=74157=74170 REVISION DETAIL

D26824: Consider empty email valid

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R128 User Manager BRANCH arcpatch-D26824 REVISION DETAIL https://phabricator.kde.org/D26824 To: meven, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n,

D26824: Consider empty email valid

meven updated this revision to Diff 74157. meven added a comment. Only fix bug REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26824?vs=74133=74157 BRANCH arcpatch-D26824 REVISION DETAIL https://phabricator.kde.org/D26824 AFFECTED FILES

D26824: Consider empty email valid

meven planned changes to this revision. meven added inline comments. INLINE COMMENTS > ngraham wrote in accountinfo.cpp:364 > This seems like the only part of the patch that's actually about fixing the > issue. The rest seems to be unrelated code cleanup that should be probably be > done

D26824: Consider empty email valid

ngraham added inline comments. INLINE COMMENTS > accountinfo.cpp:364 > if (email.isEmpty()) { > -return false; > +return true; > } This seems like the only part of the patch that's actually about fixing the issue. The rest seems to be unrelated code cleanup that

D26824: Consider empty email valid, warn user when changing selected user about potential data loss

meven updated this revision to Diff 74133. meven added a comment. Remove change that added a string REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26824?vs=74074=74133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26824 AFFECTED

D26824: Consider empty email valid, warn user when changing selected user about potential data loss

meven planned changes to this revision. meven added a comment. In D26824#598915 , @ngraham wrote: > Can't go in 5.18 because you added a new string. That part would need to go on master. So either this whole thing goes on master, or the bug gets

D26824: Consider empty email valid, warn user when changing selected user about potential data loss

ngraham added a comment. Can't go in 5.18 because you added a new string. That part would need to go on master. So either this whole thing goes on master, or the bug gets fixed in 5.18 and the new messagebox goes on master. REPOSITORY R128 User Manager REVISION DETAIL

D26824: Consider empty email valid, warn user when changing selected user about potential data loss

meven added a comment. Good candidate for Plasma/5.18 REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D26824 To: meven, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26824: Consider empty email valid, warn user when changing selected user about potential data loss

meven created this revision. meven added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Hide the meaningless kcm default button. Apart from the two changes, just Some code clean &