D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

2020-01-24 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. OK. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

2020-01-24 Thread Nathaniel Graham
ngraham added a comment. Wasn't this already fixed with D26772 ? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage, LeGast00n,

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

2020-01-24 Thread Nathaniel Graham
ngraham added a comment. Ah, looks like it landed on the stable branch but was never merged to master. Just did that. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26902 To: ahmadsamir, #plasma, davidedmundson, mart Cc: ngraham, plasma-devel, Orage,

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

2020-01-24 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, mart. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN - Make the kscreenlocker shortcut empty - Try opening systemsettings -> workspace behaviour, it crashes - Apply