D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. Uff, I screwed up landing this patch: https://cgit.kde.org/plasma-workspace.git/commit/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma, ngraham Cc: gvgeo, ngraham, plasma-devel, Orage,

D26946: Changed leftMargins to smallSpacing to be consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:149075077b82: Changed leftMargins to smallSpacing to be consistent (authored by niccolove). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26946?vs=76913=76923#toc REPOSITORY R120 Plasma

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove updated this revision to Diff 76913. niccolove added a comment. Remove spacing changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=76024=76913 BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

gvgeo added inline comments. INLINE COMMENTS > PopupDialog.qml:120 > boundsBehavior: Flickable.StopAtBounds > -spacing: Math.round(units.gridUnit / 2) > +spacing: Math.round(units.smallSpacing / 2) > I don't see why decrease this spacing. Were you able to

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Right, this is good to go now. We should remove the margin in the checkbox too. REPOSITORY R120 Plasma Workspace BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. F8146611: Screenshot_20200303_103831.png Seems aligned to me, the problem is that the new small checkbox has a margin to the left by default. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. So, with a left panel, I see the following: F8113684: Screenshot_20200219_153618.png Things are improved, but the vertical alignment is still not perfect. :( REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove updated this revision to Diff 76024. niccolove added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=74443=76024 BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. All right, feel free to re-open it and re-base on current master (there has been a lot of work to these applets lately). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma Cc: gvgeo, ngraham,

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. In D26946#602022 , @ngraham wrote: > What I care about is that the margins are consistent and things are properly left-aligned by default. That is to say, nothing should have to override the default margins to have

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. What I care about is that the margins are consistent and things are properly left-aligned by default. That is to say, nothing should have to override the default margins to have everything perfectly aligned. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. I thought about this; so, I should remove margins from everywhere, and we add them to the desktop theme? I can make that patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma Cc: gvgeo, ngraham,

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. Hmm, it almost seems like the header in the popup is over too far to the right, and we should fix that (and maybe increase the default margins in the theme: D21813 ) rather than adding extra margins in every plasmoid. REPOSITORY

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove updated this revision to Diff 74443. niccolove added a comment. Revert accidental line changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=74441=74443 BRANCH smallspacingmargin (branched from master) REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY With other two patches, this aims to make leftMargin consistent in widgets REPOSITORY R120 Plasma Workspace BRANCH