apol added a comment.
+1
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D26966
To: zzag, #plasma, broulik
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali
zzag added inline comments.
INLINE COMMENTS
> apol wrote in breezeshadowhelper.h:157
> if this is a thing, maybe it would make sense to actually try and remove the
> KWindowShadows upon destruction?
> Something like `connect(newshadow, &QObject::destroyed, this, [this, widget]
> { _shadows.rem
zzag updated this revision to Diff 74502.
zzag added a comment.
Connect to QObject::destroyed
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26966?vs=74497&id=74502
BRANCH
fix-crash
REVISION DETAIL
https://phabricator.kde.org/D26966
AFFECTED FILES
ks
broulik added inline comments.
INLINE COMMENTS
> apol wrote in breezeshadowhelper.h:157
> if this is a thing, maybe it would make sense to actually try and remove the
> KWindowShadows upon destruction?
> Something like `connect(newshadow, &QObject::destroyed, this, [this, widget]
> { _shadows.
apol added inline comments.
INLINE COMMENTS
> breezeshadowhelper.h:157
> //* managed shadows
> -QMap _shadows;
>
if this is a thing, maybe it would make sense to actually try and remove the
KWindowShadows upon destruction?
Something like `connect(newshadow, &QObject::destroye
zzag created this revision.
zzag added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.
REVISION SUMMARY
Since a KWindowShadow is a child of QWindow, we need to use a guarded
pointer to store the shadow
