D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

2020-01-29 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R31:932e5dc45410: [kstyle] Use QX11Info::isCompositingManagerRunning() (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74606=74608 REVISION

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

2020-01-29 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74606. zzag added a comment. update REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74598=74606 BRANCH use-qx11info-is-compositing-manager-active REVISION DETAIL https://phabricator.kde.org/D26978 AFFECTED

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

2020-01-29 Thread Vlad Zahorodnii
zzag added a comment. In D26978#602655 , @hpereiradacosta wrote: > In principle, the removal of Helper::connection, although is a change unrelated to the commit purpose. Maybe put it in a different commit ? Will do. (I removed it as a

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

2020-01-29 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Makes sense, thanks ! In principle, the removal of Helper::connection, although is a change unrelated to the commit purpose. Maybe put it in a different commit ?

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

2020-01-29 Thread Vlad Zahorodnii
zzag updated this revision to Diff 74598. zzag added a comment. Fix coding style. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74539=74598 BRANCH use-qx11info-is-compositing-manager-active REVISION DETAIL https://phabricator.kde.org/D26978

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

2020-01-28 Thread Vlad Zahorodnii
zzag added a comment. > monitors compositing manager selections Only if XFIXES is present; otherwise it will fallback to `xcb_get_selection_owner` as Breeze does now. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26978 To: zzag, #plasma, hpereiradacosta Cc:

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

2020-01-28 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Every time Breeze needs to check whether given widget has an alpha channel, it makes a synchronous X