D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson added a comment. My fault, I'll fix it REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Sh**t, should I make a new patch to fix this? And sorry ... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n,

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

ngraham added a comment. This broke the CI: [2020-03-24T15:59:18.523Z] [ 66%] Linking CXX shared module ../../bin/krunner_datetime.so [2020-03-24T15:59:18.523Z] /usr/home/jenkins/workspace/Plasma/kdeplasma-addons/kf5-qt5 FreeBSDQt5.14/runners/spellchecker/spellcheck.cpp:198:30:

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

This revision was automatically updated to reflect the committed changes. Closed by commit R114:5e760a0586bb: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call (authored by davidedmundson, committed by alex). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Thanks! REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma, ngraham, broulik, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson updated this revision to Diff 78368. davidedmundson added a comment. Rebase REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=78336=78368 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added a comment. Small issue: Currently this patch can't be applied (from the master branch) because in R114:47381a65debe01a0a015e1aa423cbb78af649648 the line: `QStringList terms = query.split(QLatin1Char('

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 78336. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=78335=78336 REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES runners/spellchecker/spellcheck.cpp runners/spellchecker/spellcheck.h

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 78335. alex added a comment. Minor improvements I had another look at the project and changed some other things: - optimize some overloads with QStringLiteral/QLatin1String - rename loaddata to loadData - remove the unnecessary check for the

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74848. alex added a comment. Undo changes that were supposed to be in new diff REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74847=74848 REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74847. alex added a comment. Refactoring, improve validation in kcm, optimize REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74830=74847 BRANCH charrunner_fix REVISION DETAIL

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex marked an inline comment as done. alex added a comment. Hello, thanks for the response. I addition to your requested change I have made some smaller improvements. But I have a question about the concept of this runner: Why is the data for every match session newly created ?

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74830. alex added a comment. Simplify and optimize REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74795=74830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > spellcheck.cpp:145 > { > -auto defaultSpeller = m_spellers[QString()]; > +auto = m_spellers[QString()]; > //If first term is a language

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex added reviewers: ngraham, broulik. alex added a comment. > Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years. Thanks anyway. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex,

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

vhanda added a comment. Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma Cc: vhanda, plasma-devel, Orage, LeGast00n,

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74795. alex added a comment. Simplify statement REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74793=74795 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74793. alex added a comment. Remove unused include REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74789=74793 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex created this revision. alex added reviewers: kossebau, vhanda. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The two foreach occurences are refactored and the signals in the runner/kcm now use the C++ 11