D27159: Moved the header to the bottom

2020-02-05 Thread Nathaniel Graham
ngraham added a comment. There's a more exhaustive change in D26806: [Applets/Power Manager] Update layout based on T10470 already; perhaps we should focus our efforts there? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D27159: Moved the header to the bottom

2020-02-05 Thread Kai Uwe Broulik
broulik added a comment. Same issue as with notifications: the `PowerManagementItem` shows inhibition info and other state, which makes the position of the checkbox non-deterministic REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27159 To: niccolove, #vdg

D27159: Moved the header to the bottom

2020-02-04 Thread Filip Fila
filipf added inline comments. INLINE COMMENTS > PopupDialog.qml:144 > +id: pmSwitch > +width: parent.width > +onEnabledChanged: powermanagementChanged(enabled) isn't width already defined by using `anchors.left` and `anchors.right`? REPOSITORY R120 Plasma Workspace RE

D27159: Moved the header to the bottom

2020-02-04 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > PopupDialog.qml:124 > +PlasmaCore.SvgItem { > +id: headerSeparator > +anchors { Now it's a footer, not a header REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27159 To: niccolove, #vdg Cc:

D27159: Moved the header to the bottom

2020-02-04 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Moved the header to the bottom, according to T10470 REPOSITORY R120 Plasma Workspace B