D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75144. cblack added a comment. Swap in gridUnit instead of largeSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75143=75144 BRANCH media-plasmoid-relayout (branched from master) REVISION

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75143. cblack added a comment. Remove extraneous print REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75142=75143 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75142. cblack added a comment. Add license headers to two new QML files REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75141=75142 BRANCH media-plasmoid-relayout (branched from master) REVISION

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75141. cblack added a comment. Move source selector to bottom of column, hide by default REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75140=75141 BRANCH media-plasmoid-relayout (branched from

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75140. cblack marked 7 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75138=75140 BRANCH media-plasmoid-relayout (branched from

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack marked an inline comment as done. cblack added inline comments. INLINE COMMENTS > broulik wrote in ExpandedRepresentation.qml:145-148 > Do you have a source for this claim? From what I know blur merely blurs the > actual item texture which is rendered, no the raw image source?

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75138. cblack added a comment. Cache data from the MPRIS sources REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75077=75138 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75077. cblack added a comment. Use toolbutton (for initial visual feedback; need to apply colour scheme as to prevent legibility issues) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75076=75077

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ngraham added a comment. Yeah at least with text on the side, tabs won't work at all for smaller sizes, such as in the system tray: F8087543: Screenshot_20200205_193710.png That's with just two sources! If the text were on the bottom and it

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ndavis added a comment. Looks like my previous comment is obsolete. I think tabs are more convenient than a combo box in this case, but I'm not sure this is the best use of tabs. AFAIK, we never use tabs as an actual selection control anywhere, so this behavior is unexpected. Or are

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75076. cblack added a comment. Fix plasmashell freeze REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75075=75076 BRANCH media-plasmoid-relayout (branched from master) REVISION DETAIL

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ndavis added a comment. I don't think putting the source selector on the bottom is better. It moves the buttons farther away from where the mouse would be when opening the widget on a default panel. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75075. cblack marked an inline comment as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75025=75075 BRANCH media-plasmoid-relayout (branched from

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

broulik added a comment. When there is no player it completely falls apart. It also doesn't work when there is no album art. The fallback player icon is gone. F8086262: Screenshot_20200205_093259.PNG The line spacing also seems a little

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

gvgeo added a comment. Maybe I'm wrong, don't give too much weight on these comments. INLINE COMMENTS > ExpandedRepresentation.qml:212 > > -source: mpris2Source.currentData["Desktop Icon Name"] > -visible: !albumArt.visible > +

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

manueljlin added a comment. I love how it looks :D The only thing I would change is the progress bar padding by either extending the bar to the left border to the album art or to the ~11px border from before REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

davidedmundson added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:410 > + > +width: Math.round(0.6 * parent.width) > +height: visible ? undefined : 0 Items in a layout shouldn't specify a width REPOSITORY R120 Plasma Workspace REVISION

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ngraham added inline comments. INLINE COMMENTS > cblack wrote in ExpandedRepresentation.qml:249 > F8085988: image.png All right, looks good! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg,

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack marked an inline comment as done. cblack added inline comments. INLINE COMMENTS > ngraham wrote in ExpandedRepresentation.qml:249 > Is a hardcoded white color always guaranteed to look good even when the album > art is very light? Is the blurred background always going to be dark enough?

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack updated this revision to Diff 75025. cblack marked an inline comment as done. cblack added a comment. Adjust layout of components REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=75023=75025 BRANCH media-plasmoid-relayout

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack marked 2 inline comments as done. cblack added inline comments. INLINE COMMENTS > ngraham wrote in ExpandedRepresentation.qml:178 > whitespace Whitespace is intentional to help with code legibility REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

ngraham added subscribers: manueljlin, ngraham. ngraham added a reviewer: manueljlin. ngraham added a comment. Overall very nice. I think it's a good visual direction. However it's not totally consistent with @manueljlin's mockups in T10470 so let's make

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

cblack created this revision. cblack added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The media controller has been adjusted visually. Note that this is marked as WIP due to the