D27199: [Applet]Update layout based on T10470

gvgeo added a comment. In D27199#629881 , @manueljlin wrote: > In D27199#627422 , @gvgeo wrote: > > > Differently sized icons are about to be restored in D28034

D27199: [Applet]Update layout based on T10470

manueljlin added a comment. In D27199#627422 , @gvgeo wrote: > Differently sized icons are about to be restored in D28034 . Nice! Thanks >> ...text indicator replaced with a 1px divider... Is it

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. Differently sized icons are about to be restored in D28034 . > ...text indicator replaced with a 1px divider... Is it a good idea to tweak it or is it better to leave it like it is? The alternative is the first version

D27199: [Applet]Update layout based on T10470

manueljlin added a comment. I know this is closed now, but some people from the VDG didn't like the text indicator replaced with a 1px divider and the differently sized networks. Is it a good idea to tweak it or is it better to leave it like it is? REPOSITORY R116 Plasma Network

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet. See picture below: F8145280: plasma-nm.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27199: [Applet]Update layout based on T10470

This revision was automatically updated to reflect the committed changes. Closed by commit R116:24b737bc6d5c: [Applet]Update layout based on T10470 (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27199: [Applet]Update layout based on T10470

ngraham accepted this revision. ngraham added a comment. LGTM! Nice work. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D27199_2 REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin, ngraham Cc: ngraham, plasma-devel,

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 76526. gvgeo edited the summary of this revision. gvgeo added a comment. rebase REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75906=76526 BRANCH arcpatch-D27199_2 REVISION DETAIL

D27199: [Applet]Update layout based on T10470

manueljlin accepted this revision as: manueljlin. manueljlin added a comment. Looks good, let's wait for ngraham so he accepts as vdg REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D27199_2 REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg,

D27199: [Applet]Update layout based on T10470

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. It will need rebase, there are some changes in master now which will be conflicting. Other than that I think it looks good, but I would like Nate to approve this from the UI point of

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. ping REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. The worst problem I could found, by ignoring the margins. Theme "Underworld". F8110467: Screenshot_20200218_134914.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. 1 picture, 1 problem, 2 issues. F8110442: Screenshot_20200218_124006.png I understand why margins exist. But this, is wrong. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 75906. gvgeo edited the test plan for this revision. gvgeo added a dependency: D27392: [Applet]Add info messages.. gvgeo added a comment. TODO from the last update. Improved comments. Removed fill anchor from listview. REPOSITORY R116 Plasma Network

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Thanks. Done: https://bugs.kde.org/show_bug.cgi?id=417816 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. In D27199#613246 , @ngraham wrote: > In D27199#612689 , @jgrulich wrote: > > > This is probably not related to the UI, it might be issue in the internals. Can you open a

D27199: [Applet]Update layout based on T10470

ngraham added a comment. In D27199#612689 , @jgrulich wrote: > This is probably not related to the UI, it might be issue in the internals. Can you open a bug for it? Ideally if you can restart plasmashell and enable plasma-nm debug Will

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 75831. gvgeo edited the summary of this revision. gvgeo added a dependency: D27392: [Applet]Add info messages.. gvgeo added a comment. Changes: Removed some parts that were split into separate patches. Reintroduce background. Moved highlight in

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. In D27199#611665 , @ngraham wrote: > In D27199#611308 , @gvgeo wrote: > > > I made 3 smaller patches, to decrease this patch's size. D27391

D27199: [Applet]Update layout based on T10470

ngraham added a comment. In D27199#611308 , @gvgeo wrote: > I made 3 smaller patches, to decrease this patch's size. D27391 D27392 D27393

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. I made 3 smaller patches, to decrease this patch's size. D27391 D27392 D27393 @ngraham Before I make any change here, can you tell me if you can still

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Can reproduce; it's consistent. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. Added highlight as mention, and brought back background. To do that, had to ignore, theme's margins. I need to clean code, before uploading. **I'm not so sure about this:** When a row is expanded, moving from bottom to top. **Highlight disappears with button,

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Hmm, now I see my currently connected network twice: F8100139: Screenshot_20200212_131124.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma,

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. I like it. I didn't go through the code changes yet, I'll wait until you finish it completely. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham,

D27199: [Applet]Update layout based on T10470

gvgeo planned changes to this revision. gvgeo added a comment. Clicking and highlight only on the main row, and only when hover. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc:

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Pretty nice. If the list items are no longer going to have a selection highlight but still open up/unfold when single-clicked, then the cursor should change to a pointing hand when hovering over them. REPOSITORY R116 Plasma Network Management Applet REVISION