This revision was automatically updated to reflect the committed changes.
fvogt marked an inline comment as done.
Closed by commit R111:ba7f78716af6: Only link to Qt5WebChannel if
Qt5WebEngineWidgets available (authored by fvogt).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
fvogt marked an inline comment as done.
fvogt added inline comments.
INLINE COMMENTS
> lbeltrame wrote in CMakeLists.txt:86
> Should you add a message in case one of the two is not found?
In that case `WEBENGINE_SCRIPTING_ENABLED` is `FALSE` and it'll print that
`Scripting plugin support` is
lbeltrame added inline comments.
INLINE COMMENTS
> CMakeLists.txt:86
> +set(WEBENGINE_SCRIPTING_ENABLED FALSE)
> +if(Qt5WebEngineWidgets_FOUND AND Qt5WebChannel_FOUND)
> +set(WEBENGINE_SCRIPTING_ENABLED TRUE)
Should you add a message in case one of the two is not found?
REPOSITORY
R111
fvogt updated this revision to Diff 76750.
fvogt added a comment.
This revision is now accepted and ready to land.
Treat scripting as a feature instead
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27347?vs=75550=76750
BRANCH
Plasma/5.18
fvogt added a comment.
Currently `processui/scripting.cpp` has this:
#if HAVE_QTWEBENGINEWIDGETS
#include
...
#endif
So `Qt5WebEngineWidgets` without `Qt5WebChannel` will fail to build and
`Qt5WebChannel` without `Qt5WebEngineWidgets` leads to scripting support
fvogt planned changes to this revision.
fvogt added a comment.
I need some input on how to express `HAVE_QTWEBENGINEWIDGETS` with this.
Currently it would fail to build if `Qt5WebEngineWidgets` is installed but
`Qt5WebChannel` isn't.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.
REVISION SUMMARY
QWebChannel is only used if HAVE_QTWEBENGINEWIDGETS is set.
WIP as I'm not show how to express
