This revision was automatically updated to reflect the committed changes.
Closed by commit R116:4ca1e7e34fd6: [Applet]Fix dimensions of traffic Monitor
(authored by gvgeo, committed by ngraham).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kd
ngraham accepted this revision.
ngraham added a comment.
LGTM!
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
monitor (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27391
To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: ngraham, broulik, plasma-devel, Orag
gvgeo updated this revision to Diff 75832.
gvgeo added a comment.
Added comment.
Hope it is not semi-random-looking anymore.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27391?vs=75770&id=75832
BRANCH
monitor (branched fro
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
Accepting from my side. I'll wait for Nate to do the final review as I don't
consider myself expert to QML and UI.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
monitor (
ngraham added inline comments.
INLINE COMMENTS
> TrafficMonitor.qml:64
> top: parent.top
> -topMargin: units.gridUnit
> +topMargin: Math.round(labels.labelHeight / 2)
> }
We could probably just use a smaller predefined unit, like `largeSpacing`,
ins
gvgeo updated this revision to Diff 75770.
gvgeo marked 3 inline comments as done.
gvgeo added a comment.
Remove double space.te
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27391?vs=75670&id=75770
BRANCH
monitor (branched from
gvgeo updated this revision to Diff 75670.
gvgeo edited the summary of this revision.
gvgeo added a comment.
Changes:
Added O value and aligned to the right.
Used Math.round
Made the plot's topMargin more specific. (Need to alling lines with labels)
About the label workaround:
It i
broulik added inline comments.
INLINE COMMENTS
> TrafficMonitor.qml:40
> top: parent.top
> -topMargin: Math.round(units.gridUnit / 3) + (index *
> plotter.height / 5)
> +topMargin: index * plotter.height / 5
> }
Always `Math.round` w
gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.
REVISION SUMMARY
Remove top margin.
Workaround to get paintedheight for label. (Undefined or paintedheigh
