This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2efaecee8874: [Applet]Fix details layout. (authored by
gvgeo, committed by ngraham).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
gvgeo updated this revision to Diff 75769.
gvgeo added a comment.
Remove unnecessary anchors.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27393?vs=75674=75769
BRANCH
details (branched from master)
REVISION DETAIL
gvgeo added a comment.
> Might be nice to port to ColumnLayout while we're at it
It is not really possible, what makes sense is changing to GridLayout. But
because is a similar situation with battery's info bug, I don't want to do it
together with these patches.
D26806#inline-151955
ngraham added a comment.
Might be nice to port to `ColumnLayout` while we're at it
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D27393
To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n,
gvgeo updated this revision to Diff 75674.
gvgeo added a comment.
Removed empty line.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27393?vs=75673=75674
BRANCH
details (branched from master)
REVISION DETAIL
gvgeo updated this revision to Diff 75673.
gvgeo added a comment.
Used Column as root item.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27393?vs=75658=75673
BRANCH
details (branched from master)
REVISION DETAIL
broulik added a comment.
Can we not make the `Column` the root item of the component? Then it should
propagate the size automatically.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D27393
To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik,
gvgeo added a comment.
This patch keeps left margins and opacity.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D27393
To: gvgeo, #plasma, #vdg, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.
REVISION SUMMARY
Fix binding loop with detailValueLabel's width.
Remove workaround for contentRect
