D27407: Breeze widgetStyle value is Breeze

meven added inline comments. INLINE COMMENTS > defaults:8 > [kdeglobals][Icons] > Theme=breeze > ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage,

D27407: Breeze widgetStyle value is Breeze

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c7c190488e46: Breeze widgetStyle value is Breeze (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27407?vs=75699=75909 REVISION

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. Will do in a separate commit. I guess it's more or less related to the KCM Style. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage,

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. Separate commit is probably fine, but if this lands on the stable branch, it should come soon. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham,

D27407: Breeze widgetStyle value is Breeze

ervin added a comment. Shall we expect the migration script in that patch or another one? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. Sounds like it will provide a complete fix, the update script will fix the issue without requiring the user to reset its application style, and this patch will ensure it won't come back. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. Could we maybe ship a kconfig update script to change the string in the config file for people who don't ever change their global theme? Or is the problem moot because the global theme gets automatically applied on upgrade or something? REPOSITORY R120 Plasma

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. In D27407#611723 , @ngraham wrote: > This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. So this is clearly a correct fix, but I'm not sure it's sufficient to fully resolve 417515. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson Cc: ngraham, plasma-devel,

D27407: Breeze widgetStyle value is Breeze

ngraham added a comment. This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for that use case though. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27407: Breeze widgetStyle value is Breeze

crossi added a subscriber: ngraham. crossi added a comment. @ngraham my bad, didn't see your edit ^^ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27407: Breeze widgetStyle value is Breeze

crossi created this revision. crossi added reviewers: ervin, bport, meven, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 414885 REPOSITORY R120 Plasma Workspace REVISION DETAIL