D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. ...and now the split is complete. https://phabricator.kde.org/D27466 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, an

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. The initial patch of the three, now I've thought up a suitable way of doing this, has been made: https://phabricator.kde.org/D27465 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. Actually, on second thought, @ngraham I'm not even sure if step 2 would even be worth it on its own, if possible. On your suggestion you have it adjusted to have step 3's tablet mode checker in step 2. If I don't have that check in place, for step 2, the

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613097 , @ngraham wrote: > ...one to increase the spacing when in tablet mode, and another one to increase the spacing when in desktop mode. At this point each patch will be changing a different line i

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev abandoned this revision. The-Feren-OS-Dev added a comment. Alright, I'll start splitting the patches up now. Marking this one as Abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre C

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613104 , @IlyaBizyaev wrote: > I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: > > Does this depend on DPI/panel size maybe?

D27438: Increase System Tray Plasmoid spacing value slightly

IlyaBizyaev added a comment. I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: Does this depend on DPI/panel size maybe? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Fe

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches It would probably be simplest do just do this though: 1. Abandon this patch 2. Submit a patch to refactor that logic to use a nested multi-line function for

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. How would I split it into two patches? Both patches would edit the exact same line. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: broulik, kmaterka, filipf, ndavis, a

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. This should probably be two patches at this point: one to increase the spacing when using tablet mode (which IMO is an uncontroversial no-brainer) and another to increase the spacing when in desktop mode. INLINE COMMENTS > main.qml:45 > +// If Kirigami.Settings.

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75851. The-Feren-OS-Dev added a comment. Tweaked an added comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75850&id=75851 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613051 , @davidre wrote: > In D27438#613050 , @The-Feren-OS-Dev wrote: > > > In D27438#612719 , @davidre wrote:

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75850. The-Feren-OS-Dev added a comment. Changed method used for increasing spacing between tray icons to something that increases hitbox sizes as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D27438: Increase System Tray Plasmoid spacing value slightly

davidre added a comment. In D27438#613050 , @The-Feren-OS-Dev wrote: > In D27438#612719 , @davidre wrote: > > > There is now not clickable space between items: > > F8108239: grafik.png

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#612719 , @davidre wrote: > There is now not clickable space between items: > F8108239: grafik.png F8108241: grafik.png

D27438: Increase System Tray Plasmoid spacing value slightly

broulik added a comment. F8108249: Screenshot_20200217_101015.PNG The spacing I have here currently is already excessive imho. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham

D27438: Increase System Tray Plasmoid spacing value slightly

davidre requested changes to this revision. davidre added a comment. This revision now requires changes to proceed. There is now not clickable space between items: F8108239: grafik.png F8108241: grafik.png At lea

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75804. The-Feren-OS-Dev added a comment. One more patch update to keep the change consistent with the rest of the code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75803&id=75804 BRANCH m

D27438: Increase System Tray Plasmoid spacing value slightly

kmaterka added a comment. There is already a margin added around icons, "units.smallSpacing / 2" if I remember correctly. IMO it is OK without additional spacing (maybe because I'm used to it?). Anyway, VDG should decide what is the best and what is consistent with other elements of Plasm

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham accepted this revision as: ngraham. ngraham added a comment. Hopefully people won't murder us over one pixel. :) IMO time to finish the bikeshedding if VDG people are happy with it and everyone else can tolerate it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. Fair point, just checked that now and they're indeed the same. Got confused with 0.65 as 0.65 looks different to 0.5. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: filipf, ndavis, anth

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75803. The-Feren-OS-Dev added a comment. Went to 0.5, because 0.6 indeed looks just like 0.5 in execution REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75800&id=75803 BRANCH master REVISI

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. 2*0.7 rounded down is going to be 1. Just divide `units.smallSpacing` by two if you want 1. But then I have to wonder... is it really worth it to add one pixel of spacing? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438

D27438: Increase System Tray Plasmoid spacing value slightly

filipf added a comment. copy paste from Telegram > fwiw I like units.smallSpacing / 2 more but it's not that big of a difference REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: filipf, ndavis, anthonyfieroni, davidr