D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev updated this revision to Diff 75800. The-Feren-OS-Dev added a comment. Changed value to Math.round(units.smallSpacing * 0.7) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75785&id=75800 BRANCH master REVISION DETAIL

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Nevermind, then, I guess something changed between now and Plasma 5.18.1 master code meaning that no longer works, back to the old method... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg C

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev planned changes to this revision. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Managed to come to a good compromise, however now I've hit a bit of a roadblock. I've found that by editing these lines: property int left: Math.r

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. After a bit more digging around the code, I found another alternative way to do this which also fixes a bug I just noticed with this patch (there's clicking deadzones in-between the tray icons), however the method for doing it causes this spacing: F8107

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

davidre added a comment. After clicking through the before after I still think it's to much REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Fe

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. In D27438#612484 , @ngraham wrote: > Also, it's nice to have the "after" versions right after each corresponding "before" version so you can more easily compare them by clicking on one and navigating between the

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ngraham added a comment. Also, it's like to have the "after" versions right after each corresponding "before" version so you can more easily compare them by clicking on one and navigating between them with the arrow keys. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabr

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. In D27438#612463 , @ngraham wrote: > To make this patch easier to review without applying it, please add all the various sets of before-and-after images to the Test Plan section, not in comments. Done.

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ngraham resigned from this revision. ngraham added a comment. I have a vertical panel and use large tray icons but intentionally minimize their number, and the result looks fine to me IMO: F8107338: Screenshot_20200216_115030.png However I'll admit

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. VS same but with / 2: F8107328: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: ndavis, anthonyfieroni, davidre, ngraham, plasm

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. In D27438#612459 , @ndavis wrote: > Please check how this looks with a vertical panel. Looks a whole lot better on Vertical than without spacing IMHO (unitSpacing): F8107323: image.png

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ndavis added a comment. Please check how this looks with a vertical panel. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-D

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

ndavis added a comment. In D27438#612440 , @The-Feren-OS-Dev wrote: > Which one would people prefer? > Units.smallSpacing: > F8107285: image.png > > Units.smallSpacing / 2: > F8107287: image.png

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Which one would people prefer? Units.smallSpacing: F8107285: image.png Units.smallSpacing / 2: F8107287: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL ht

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Would people prefer that above design to 4px? ^ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-De

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

The-Feren-OS-Dev added a comment. Here's it with / 2 added to the spacing value: F8107253: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: anthonyfieroni, davidr

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

anthonyfieroni added a comment. F8107246: Screenshot_20200216_195252.png How it looks now with 0 spacing, with 2 will have no space in panel at all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

anthonyfieroni added a comment. Maybe units.smallSpacing / 2, i'm pretty sure people that use show all entries in systray will be unhappy to see no free space in their panels. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg,

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

davidre added a comment. I think 0 doesn't look cramped at all. Increasing the spacing also increases the space usage . -1 from me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham Cc: davidre, ngraham, plasma-devel,