D27823: Use consistent highlight

gvgeo added a comment. Couple of notes, as I'm not sure what the aim was here. I have not test it, take them with a grain of salt. - Highlight area was changed, without changing the click area. - Connect button pop up area change, was not documented. - Highlight svg is not consistent

D27823: Use consistent highlight

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b7291760dce1: Use consistent highlight (authored by niccolove). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77254=77310

D27823: Use consistent highlight

ngraham accepted this revision. ngraham added a comment. Thanks, everything works now. :) I don't see that extra line in mine. But yeah, if it's reproducible, it's a bug that should be fixed. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27823: Use consistent highlight

niccolove added a comment. Sorry, I had different files with different versions. Now it shows correctly for me, with all files up to date. That said, is it normal that: F8167163: image.png - the top elements has a top separator - icon size of

D27823: Use consistent highlight

niccolove updated this revision to Diff 77254. niccolove added a comment. ops REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77253=77254 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove updated this revision to Diff 77253. niccolove added a comment. fixed name of list REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77219=77253 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

ngraham added a comment. Now I see no highlight effect at all. Does this work for you? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n,

D27823: Use consistent highlight

niccolove added a comment. Should now work? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77219. niccolove added a comment. remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77218=77219 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove updated this revision to Diff 77217. niccolove added a comment. remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77215=77217 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove updated this revision to Diff 77218. niccolove added a comment. ops REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77217=77218 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

ngraham added a comment. Does this work for you? I still see the old highlight. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n,

D27823: Use consistent highlight

ngraham added a comment. There we go, much better now. :) Reviewing... REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77215. niccolove added a comment. rebase x3 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77214=77215 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

davidre added a comment. Probably your arc diff base target thingy didn't switch and is on the old commit so this includes everything new on the master branch. Specify it manually with `arc diff master` or `arc diff origin/master` REPOSITORY R116 Plasma Network Management Applet REVISION

D27823: Use consistent highlight

niccolove added a comment. well fuck. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77214. niccolove added a comment. rebase x2 REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77212=77214 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

ngraham added a comment. you need to rebase on top of `master` from the remote. This looks to have been branched off of the state of master from last November or something. Try `git pull --rebase origin master` That should give you some merge conflicts that you can fix. REPOSITORY

D27823: Use consistent highlight

niccolove updated this revision to Diff 77212. niccolove added a comment. rebase REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77203=77212 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

ngraham added a comment. Now it needs a rebase, as there are merge conflicts. :) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77203. niccolove added a comment. Fixed double declaration REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77004=77203 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConnectionItem.qml:54 > > +onContainsMouseChanged: { > +if (containsMouse) { `ConnectionItem.qml` already has `onContainsMouseChanged` (at

D27823: Use consistent highlight

niccolove updated this revision to Diff 77004. niccolove added a comment. Nope REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77003=77004 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove updated this revision to Diff 77003. niccolove added a comment. Right margin of button REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=77001=77003 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove added a comment. Ah, this one. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27823: Use consistent highlight

niccolove updated this revision to Diff 77001. niccolove added a comment. Remove old highlight REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27823?vs=76911=77001 BRANCH highlight (branched from master) REVISION DETAIL

D27823: Use consistent highlight

niccolove added a comment. In D27823#621958 , @ngraham wrote: > This needs a rebase. Also you probably need to delete the existing mouseover highlight effect. Git is telling me this is up to date. Also, what existing mouseover effect?

D27823: Use consistent highlight

ngraham added a comment. This needs a rebase. Also you probably need to delete the existing mouseover highlight effect. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27823 To: niccolove, jgrulich, #vdg Cc: ngraham, plasma-devel, Orage,

D27823: Use consistent highlight

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. niccolove requested review of this revision. REVISION SUMMARY Use the PlasmaComponents.Highlight feature to be consistent with other lists. REPOSITORY