D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma, niccolove, cblack Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. strong +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. I'm going to stand firm on 2.5x gridUnit for now. That works out to 46px, which is not too tall (IMO) and increases touch friendliness by a lot. Let's all keep in mind that this is super easily configurable. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. We discussed this and D29501 at the virtual plasma sprint today and concludes that we should probably do the horizontal version here. Nobody overtly hated the vertical version, but issues displaying the clock +date and system

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. There's still disagreement over whether we should do this or the other one, and how to implement them, so I don't think we know what release one of them will land in (if any). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

rikmills added a comment. Is this to land in 5.19? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel, Orage,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Every change upsets somebody; that's not a reason to avoid change. We change things when the proposed change is a universal or net improvement, and we leave things the same when it would be worse or no better. So you should evaluate that (and any) patch on its

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

KonqiDragon added a comment. In D27845#665342 , @ngraham wrote: > Since I'm not feeling a lot of enthusiasm for this patch, I've submitted an alternative that fully implements the proposal in T12441 with no

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Since I'm not feeling a lot of enthusiasm for this patch, I've submitted an alternative that fully implements the proposal in T12441 with no design compromises: D29501: Use left-aligned thickened panel with IOTM populated with

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. So now with this patch, the new default panel height is 46px. It seems like there's still a camp that would prefer a smaller value, though and I don't want to steamroll over them. However I agree with @veggero that the 42 and 44px sizes look odd given the current

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 82142. ngraham added a comment. Round up to nearest even number REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=82140=82142 BRANCH iotm-by-default (branched from master) REVISION DETAIL

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 82140. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=79514=82140 BRANCH iotm-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D27845

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. Size should be an even number - For sizes from 36 to 40, I'm OK with it - At 42 and 44 the icons in the task manager become too big for the panel; their size should be reduced to same as the launcher button, then it's fine - At 46 and over it's fine

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. The blocking bug was just fixed with D28632 , therefore... ping! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: mart, filipf, kmaterka, gvgeo,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 79514. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=77053=79514 BRANCH iotm-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D27845

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

gvgeo added a comment. Are there objections for `Math.round(gridUnit * 2.33)` (42 with default settings) suggested by @filifp? So that it can have big icons. In D27845#622739 , @ndavis wrote: > I don't want to turn this into bikeshedding,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#623019 , @mart wrote: > In D27845#622178 , @ngraham wrote: > > > Not as touch-friendly, but the clock text looks better and it won't be so huge for people using

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

mart added a comment. In D27845#622178 , @ngraham wrote: > Not as touch-friendly, but the clock text looks better and it won't be so huge for people using low-DPI screens. However 38 is not easy to calculate by our existing units so it would

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

filipf added inline comments. INLINE COMMENTS > layout.js:28 > +// For an Icons-Only Task Manager on the bottom, *3 is too much, *2 is too > little > +panel.height = Math.round(gridUnit * 2.5) > can we do `Math.round(gridUnit * 2.25)` or at least `Math.round(gridUnit * 2.33)` ? That's

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#622970 , @kmaterka wrote: > Should System Tray icons be larger then? Here's how it would look to go from `iconSize=1` to `iconSize=2` (i.e, 16px to 22px): F815: Bigger.png

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 77053. ngraham added a comment. Use a gridUnit-based measurement again, and increase the thickness a bit to effectively 46px tall, which I really don't think is excessive REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

kmaterka added a comment. Should System Tray icons be larger then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: kmaterka, gvgeo, davidedmundson, ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev, plasma-devel, Orage,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. @davidedmundson one problem here is that a `gridUnit` is a fairly coarse unit of measurement, and gridUnit * 3, or 54px is a bit larger than we'd like, but the current thickness (gridUnit *2, or 36px) is too thin. We initially settled on something in the mid 40s,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

gvgeo added a comment. IMO better use Math.round(gridUnit*2.1) than fixed value that will not always look good with a scaled display. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: gvgeo, davidedmundson, ndavis,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. @davidedmundson Nate says smallSpacing doesn't work here. Do you know why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: davidedmundson, ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

davidedmundson added inline comments. INLINE COMMENTS > layout.js:28 > > -panel.height = gridUnit * 2 > +// Same as the default height of the Windows panel > +panel.height = 38 I'm seeing this on too many tickets where we replace doing any design and thinking for being lazy copy cats. If

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in layout.js:29 > why is this no longer unit based Because VDG people wanted a size that isn't a multiple or clean divisor of `gridUnit` and none of the other units values would evaluate for some reason. Some people think

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

davidedmundson added inline comments. INLINE COMMENTS > layout.js:29 > +// Same as the default height of the Windows panel > +panel.height = 38 > why is this no longer unit based REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. In D27845#622739 , @ndavis wrote: > I don't want to turn this into bikeshedding, but I think a size of 42 is better because that raises the size of task manager icons to 32px. 22px is pretty small for an IOTM. > With

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. In D27845#622434 , @KonqiDragon wrote: > Why Show/Hide Desktop icon is so huge? Because icon sizing in panels is a mess. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To:

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. I don't want to turn this into bikeshedding, but I think a size of 42 is better because that raises the size of task manager icons to 32px. 22px is pretty small for an IOTM. With that said, I think something we'll have to work on is finding ways to improve the way

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

KonqiDragon added a comment. In D27845#622551 , @niccolove wrote: > The plasma logo is also quite big. For reference, here's my 38px panel: > F8152196: image.png It's looks so small (to me), but

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. The plasma logo is also quite big. For reference, here's my 38px panel: F8152196: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: KonqiDragon,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

KonqiDragon added a comment. In D27845#622178 , @ngraham wrote: > Some folks in the #VDG channel have objected to the panel being 48px tall, so here's how it would look at 38 (the default Windows panel

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 76967. ngraham added a comment. Use 38px as the height, and hardcode it since there's no good way to get there with a multiple of `gridUnit` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=76966=76967

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Now to my eyes, 38px is too small. But apparently my tired old eyes and small screen (13.3" FHD) are not representative of other VDG people's views. :) Still it makes me realize that we really need to get https://bugs.kde.org/show_bug.cgi?id=356446 done so that

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. +1 to 38 Weirdly enough, the plasma icon only looks that big from >40, while the IOTM does not use big icons in 40 yet. I'd like small icons to be used consistently. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To:

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Some folks in the #VDG channel have objected to the panel being 48px tall, so here's how it would look at 38 (the default Windows panel height): F8149938: 38.png Not as

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Sounds like a bug we should fix with the `preferred://` schemas then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

The-Feren-OS-Dev added a comment. `applications:systemsettings.desktop,applications:org.kde.discover.desktop,preferred://filemanager,preferred://browser` There is currently an issue that might make this cumbersome, unless it was fixed very recently as part of the patch work for this,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. One other note: it might make sense to turn on the Digital Clock's date display by default if we go with this, as the clock text is currently rather gigantic and IMO adding the date results in both more information and also a better use of space: F8149908:

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements the part of T12441 that was