D27869: Separate processcore/{formatter,unit} into its own library

2020-03-23 Thread Arjen Hiemstra
ahiemstra added a comment. See https://phabricator.kde.org/D28217 for a fix for that. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D27869 To: ahiemstra, #plasma, davidedmundson Cc: arfrever, zzag, ngraham, plasma-devel, Orage, LeGast00n,

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-21 Thread Arfrever Frehtes Taifersar Arahesis
arfrever added a comment. cmake fails with: ... -- Configuring done CMake Error at formatter/declarative/CMakeLists.txt:3 (add_library): Target "FormatterPlugin" links to target "Qt5::Qml" but the target was not found. Perhaps a find_package() call is missing for an

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-19 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R111:182fbd95dc94: Separate processcore/{formatter,unit} into its own library (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-05 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > ahiemstra wrote in unit.h:81 > Blame @zzag for that who wrote the original code. :P > > That said, we probably should consider how to deal with localization issues > like that at some point in the future. Oops, sorry. REPOSITORY R111 KSysguard

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-05 Thread Arjen Hiemstra
ahiemstra added a subscriber: zzag. ahiemstra added inline comments. INLINE COMMENTS > ngraham wrote in unit.h:81 > No Fahrenheit for us poor Americans? :) Blame @zzag for that who wrote the original code. :P That said, we probably should consider how to deal with localization issues like

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-05 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 77038. ahiemstra added a comment. - Fix qmldir file - Also register meta type of MetricPrefix so it can actually be used - Add a manual test to test how Formatter works from QML REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-05 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > unit.h:81 > -// Misc units. > -UnitCelsius = 500, > -UnitDecibelMilliWatts, No Fahrenheit for us poor Americans? :) REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D27869 To: ahiemstra, #plasma Cc:

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-05 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 77027. ahiemstra added a comment. - More minor corrections REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27869?vs=77025=77027 BRANCH formatter_lib REVISION DETAIL https://phabricator.kde.org/D27869

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-05 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 77025. ahiemstra added a comment. - Correct comment REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27869?vs=77024=77025 BRANCH formatter_lib REVISION DETAIL https://phabricator.kde.org/D27869

D27869: Separate processcore/{formatter,unit} into its own library

2020-03-05 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This moves Formatter and Unit out of ProcessCore and into its own Formatter library.