D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

ngraham added a comment. Sorry, I wasn't clear. I mean, I think it would be nice if adjacent quick-tiled windows didn't show shadows on their shared edges. Quick tiled windows would still show shadows on their edges that are not toughing a screen edge or another quick tiled window

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. In D27892#628432 , @ngraham wrote: > In D27892#628109 , @davidre wrote: > > > Please note that his doesn't disable shadows completely for quick tiled windows, only on the

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

ngraham added a comment. In D27892#628109 , @davidre wrote: > Please note that his doesn't disable shadows completely for quick tiled windows, only on the edges that it is tiled to. Personally I think that would be worthwhile, if we had

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. In D27892#628090 , @zzag wrote: > Yes, whether tiled windows should cast shadows is something that must be decided by the compositor or ultimately implemented somewhere in KDecoration2 (not a big fan of this though).

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

zzag added a comment. Yes, whether tiled windows should cast shadows is something that must be decided by the compositor or ultimately implemented somewhere in KDecoration2 (not a big fan of this though). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To:

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

hpereiradacosta added a comment. In D27892#623436 , @davidre wrote: > In D27892#623425 , @ngraham wrote: > > > +1 for the concept and resulting appearance. But, should this maybe be done in KWin

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. ping REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre, #breeze, #vdg, zzag, hpereiradacosta Cc: davidedmundson, ngraham, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a subscriber: davidedmundson. davidre added a comment. In D27892#623425 , @ngraham wrote: > +1 for the concept and resulting appearance. But, should this maybe be done in KWin instead? That way all window decoration themes would

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

ngraham added a comment. +1 for the concept and resulting appearance. But, should this maybe be done in KWin instead? That way all window decoration themes would get this fix/change, not just Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre,

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > + > +set_target_properties(breezedecoration PROPERTIES CXX_STANDARD 17) > if(BREEZE_HAVE_X11) Sorry, that was just for the initial version of this patch to allow for static inline variables to arrive at the first

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > + > +set_target_properties(breezedecoration PROPERTIES CXX_STANDARD 17) > if(BREEZE_HAVE_X11) That's too offensive. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre, #breeze,

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. What happens is maybe more clear when using custom window shadows: F8154350: Screenshot_20200306_133119.PNG F8154374: Screenshot_20200306_133130.PNG F8154369:

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre updated this revision to Diff 77094. davidre added a comment. set padding REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27892?vs=77092=77094 BRANCH shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D27892 AFFECTED

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY For a quick tiled window we currently don't draw a border on the edges it is tiled to but we still draw a shadow. In a one screen