This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3f0ca0da37d8: appstreamrunner: Port to KApplicationTrader
(authored by apol).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D27954?vs=77469=77602#toc
REPOSITORY
R120 Plasma Workspace
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> appstreamrunner.cpp:102
> +return true;
> +} else {
> +const auto renamedFrom =
>
apol added inline comments.
INLINE COMMENTS
> dfaure wrote in appstreamrunner.cpp:96
> Note that the original trader query used =~ which meant "case insensitive
> comparison".
> I have no idea if it was necessary though.
Might have just chosen the wrong operator, it's part of the problem of
apol updated this revision to Diff 77469.
apol added a comment.
Remove unnecessary check
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27954?vs=77306=77469
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27954
AFFECTED FILES
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Cool to see KApplicationTrader being used :-)
INLINE COMMENTS
> appstreamrunner.cpp:96
> +
> +if (service->desktopEntryName() == componentId)
> +
apol created this revision.
apol added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Port away from the query language to lambda using the new KApplicationTrader
API.
Depends on
