D27982: use better strings for dri devices

2020-04-03 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R102:b7d462e03ce9: use better strings for dri devices (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27982?vs=77417=79218#toc REPOSITORY R102 KInfoCenter CHANGES SINCE

D27982: use better strings for dri devices

2020-03-11 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > ngraham wrote in opengl.cpp:284 > What does "Card" mean in this context? A graphics card? Relates to D27980 a card here is a "3D Accelerator" "Card". whatever that means... It's a graphics card essentially,

D27982: use better strings for dri devices

2020-03-11 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > opengl.cpp:284 > auto info = get_dri_device_proc(QStringLiteral("/proc/dri/") + entry > + QStringLiteral("/name")); > -info.deviceId = entry; > +info.deviceId = i18nc("%1 is a DRI card index integer", "Card %1", >

D27982: use better strings for dri devices

2020-03-11 Thread Harald Sitter
sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the /proc based fallback was using the raw entry name (number) to avoid a new string in 5.18. the Accelerator grouping entry