D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629829 , @ahmadsamir wrote: > Anyway, the important thing is that the test passes on the CI system. Okay, that's good! We still have that qDeleteAll in ~ShadowHelper(), not sure what we have to do about it

D28075: [kstyle] Properly unregister widgets in ShadowHelper

ahmadsamir added a comment. Could be something on my system no idea what though. Sorry for the noise. Anyway, the important thing is that the test passes on the CI system. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28075 To: zzag, #plasma, cblack Cc: ahma

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629808 , @ahmadsamir wrote: > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: > > Thread 1 "kdatetimeeditte" received signal SIG

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. In D28075#629808 , @ahmadsamir wrote: > FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: > > Thread 1 "kdatetimeeditte" received signal SIG

D28075: [kstyle] Properly unregister widgets in ShadowHelper

ahmadsamir added a comment. FWIW, I have the kdatetimeedittest unit test from KWidgetAddons fail with a SIGSEGV even after building breeze with this diff: Thread 1 "kdatetimeeditte" received signal SIGSEGV, Segmentation fault. 0x70c6c770 in qDeleteAll::const_iterator> (begin

D28075: [kstyle] Properly unregister widgets in ShadowHelper

This revision was automatically updated to reflect the committed changes. Closed by commit R31:49fdd73e1629: [kstyle] Properly unregister widgets in ShadowHelper (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28075?vs=77727&id=77893 REVISION

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY After a widget has been unregistered, a WinIdChange event may be sent. If that happens, ShadowHelper is g