D28081: Populate Greeter process exit stderr

2020-03-28 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R133:c893e333b060: Populate Greeter process exit stderr (authored by romangg). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28081?vs=77784=78759 REVISION

D28081: Populate Greeter process exit stderr

2020-03-17 Thread Roman Gilg
romangg added a comment. In D28081#628985 , @davidedmundson wrote: > Can we use categorised logging please. Yea, but I haven't seen any categorized logging in KScreenLocker so I opted for now with non-categorized logging as the rest of

D28081: Populate Greeter process exit stderr

2020-03-17 Thread David Edmundson
davidedmundson added a comment. Can we use categorised logging please. But general +1 REPOSITORY R133 KScreenLocker BRANCH debug REVISION DETAIL https://phabricator.kde.org/D28081 To: romangg, #plasma, apol Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n,

D28081: Populate Greeter process exit stderr

2020-03-16 Thread Roman Gilg
romangg updated this revision to Diff 77784. romangg added a comment. else case REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28081?vs=5=77784 BRANCH debug REVISION DETAIL https://phabricator.kde.org/D28081 AFFECTED FILES

D28081: Populate Greeter process exit stderr

2020-03-16 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > zzag wrote in ksldapp.cpp:256 > Shouldn't it be in an else branch? Yes, thanks! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28081 To: romangg, #plasma Cc: zzag, plasma-devel, Orage, LeGast00n,

D28081: Populate Greeter process exit stderr

2020-03-16 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > ksldapp.cpp:256 > } > +qCritical("Greeter process exitted and we could in no way > recover from that!"); > } Shouldn't it be in an else branch? REPOSITORY R133 KScreenLocker REVISION DETAIL

D28081: Populate Greeter process exit stderr

2020-03-16 Thread Roman Gilg
romangg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Give more info in debug output when and how the Greeter porcess exited and what counter-measures are triggered to unregular