D28086: Improve CMake handling of GNOME libraries

gikari added a comment. Everything is fine on CI. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma, gikari, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28086: Improve CMake handling of GNOME libraries

This revision was automatically updated to reflect the committed changes. Closed by commit R99:7f7a57095cf1: Improve CMake handling of GNOME libraries (authored by cblack). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=78590=78803

D28086: Improve CMake handling of GNOME libraries

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Ok, let's keep our eyes on CI now. Everything should be fine, since the dependencies didn't change. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH arcpatch-D28086 REVISION DETAIL

D28086: Improve CMake handling of GNOME libraries

cblack updated this revision to Diff 78590. cblack added a comment. Drop giomm REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=77833=78590 BRANCH arcpatch-D28086 REVISION DETAIL https://phabricator.kde.org/D28086 AFFECTED

D28086: Improve CMake handling of GNOME libraries

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:22 > +pkg_check_modules(GIO REQUIRED IMPORTED_TARGET gio-2.0) > +pkg_check_modules(giomm REQUIRED IMPORTED_TARGET giomm-2.4) > + If I understand correctly this line is redundant. > CMakeLists.txt:7 >

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. See https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/49 for possible resolution REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma, gikari, apol Cc: apol, plasma-devel, Orage, LeGast00n,

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. This has been reverted. @cblack, please take a look at what has happened. Seems like CI is missing some dependency. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28086: Improve CMake handling of GNOME libraries

This revision was automatically updated to reflect the committed changes. Closed by commit R99:db87b4d270a1: Improve CMake handling of GNOME libraries (authored by cblack). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=77831=77833

D28086: Improve CMake handling of GNOME libraries

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Fine. It builds. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched from master) REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack,

D28086: Improve CMake handling of GNOME libraries

cblack added a comment. In D28086#628957 , @gikari wrote: > It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` module? It actually uses it inside already, but with some bugs, that prevents from building last patch.

D28086: Improve CMake handling of GNOME libraries

cblack updated this revision to Diff 77831. cblack added a comment. Rebase on master for reverted commits REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=77790=77831 BRANCH better-gtk-glib-etc-usage (branched from master)

D28086: Improve CMake handling of GNOME libraries

gikari requested changes to this revision. gikari added a comment. This revision now requires changes to proceed. I reverted the commits ( R99:306e01d86ab9a891ec70219802ce01572b0d4025 and

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` module? It actually uses it inside already, but with some bugs, that prevents from building last patch. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched

D28086: Improve CMake handling of GNOME libraries

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Good stuff! REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched from master) REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma,

D28086: Improve CMake handling of GNOME libraries

cblack created this revision. cblack added reviewers: Plasma, gikari. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY GNOME libraries were being handled in a manner not as elegant as possible with CMake's