D28096: Don't overwrite status

2020-03-17 Thread Konrad Materka
kmaterka added a comment. > Oh you're right. It was not wokring for me on 5.18 so I changed this and it worked. But matter of fact it worked on master all allong :) 5.18 is not using this data model, in 5.18 it is used only in configuration page. In 5.19 this model is everywhere.

D28096: Don't overwrite status

2020-03-17 Thread David Redondo
davidre abandoned this revision. davidre added a comment. In D28096#629508 , @kmaterka wrote: > > The qml checks the value against the enum but updateItemData inserts the string. > > These are two different roles: > "status" with enum

D28096: Don't overwrite status

2020-03-17 Thread Konrad Materka
kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. > The qml checks the value against the enum but updateItemData inserts the string. These are two different roles: "status" with enum value "Status" from SNI data

D28096: Don't overwrite status

2020-03-17 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. TEST PLAN set an attentionIconByName in kstatusnotifieritemtest REPOSITORY R120 Plasma Workspace BRANCH attention (branched from master)